Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1369263004: Make the dartWrapper access on JsObject private and provide top-level functions for it (Closed)

Created:
5 years, 2 months ago by Alan Knight
Modified:
5 years, 2 months ago
Reviewers:
terry, Jacob
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make the dartWrapper access on JsObject private and provide top-level functions for it BUG= R=jacobr@google.com Committed: https://github.com/dart-lang/sdk/commit/eafe9d6b60ae10df649d26e0c8987c9fb713af53

Patch Set 1 #

Patch Set 2 : Fix typo #

Total comments: 2

Patch Set 3 : Review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -7 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M sdk/lib/js/dartium/js_dartium.dart View 1 2 2 chunks +17 lines, -1 line 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 2 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Alan Knight
5 years, 2 months ago (2015-10-01 21:30:34 UTC) #2
Jacob
lgtm. minor nit. tweak the names to make it clearer this is for dart:html https://codereview.chromium.org/1369263004/diff/20001/sdk/lib/js/dartium/js_dartium.dart ...
5 years, 2 months ago (2015-10-01 21:33:47 UTC) #3
Alan Knight
https://codereview.chromium.org/1369263004/diff/20001/sdk/lib/js/dartium/js_dartium.dart File sdk/lib/js/dartium/js_dartium.dart (right): https://codereview.chromium.org/1369263004/diff/20001/sdk/lib/js/dartium/js_dartium.dart#newcode487 sdk/lib/js/dartium/js_dartium.dart:487: dartWrapperFor(JsObject object) => object._dartWrapper; On 2015/10/01 21:33:47, Jacob wrote: ...
5 years, 2 months ago (2015-10-01 22:10:09 UTC) #4
Alan Knight
5 years, 2 months ago (2015-10-01 22:10:53 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
eafe9d6b60ae10df649d26e0c8987c9fb713af53 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698