Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1369243002: Update upstream bots to target iOS SDK 9.0. (Closed)

Created:
5 years, 2 months ago by sdefresne
Modified:
5 years, 2 months ago
Reviewers:
smut, justincohen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update upstream bots to target iOS SDK 9.0. Xcode 7.0 has been publicly released and iOS downstream requires it to build so use the iOS 9.0 SDK with Xcode 7.0 for the bots upstream. Run the tests on all the currently supported iOS version 7.1, 8.3 and 9.0. BUG=516606 Committed: https://crrev.com/e25b47b53a88620d1d22e7466e44574bfc4acc5b Cr-Commit-Position: refs/heads/master@{#351178}

Patch Set 1 #

Patch Set 2 : Use iOS SDK 8.3 instead of 8.4 as 8.4 is not installed on the bots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -24 lines) Patch
M ios/build/bots/chromium.fyi/Chromium_iOS_Device.json View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/build/bots/chromium.fyi/Chromium_iOS_Device_(ninja).json View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/build/bots/chromium.fyi/Chromium_iOS_Simulator_(dbg).json View 1 1 chunk +13 lines, -3 lines 0 comments Download
M ios/build/bots/chromium.mac/iOS_Device.json View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/build/bots/chromium.mac/iOS_Device_(ninja).json View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/build/bots/chromium.mac/iOS_Simulator_(dbg).json View 1 1 chunk +13 lines, -3 lines 0 comments Download
M ios/build/bots/tryserver.chromium.mac/ios_dbg_simulator.json View 1 1 chunk +13 lines, -3 lines 0 comments Download
M ios/build/bots/tryserver.chromium.mac/ios_dbg_simulator_ninja.json View 1 1 chunk +13 lines, -3 lines 0 comments Download
M ios/build/bots/tryserver.chromium.mac/ios_rel_device.json View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/build/bots/tryserver.chromium.mac/ios_rel_device_ninja.json View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
sdefresne
Please take a look.
5 years, 2 months ago (2015-09-28 12:22:46 UTC) #3
sdefresne
Please take a look.
5 years, 2 months ago (2015-09-28 12:22:47 UTC) #4
sdefresne
PTAL
5 years, 2 months ago (2015-09-28 15:36:19 UTC) #6
smut
Time difference. It was like 5am for me and 8am when you re-sent. (: Lgtm.
5 years, 2 months ago (2015-09-28 20:15:24 UTC) #7
smut
Gonna CQ in a sec. I'm just checking the non-CQ iOS try bots (they use ...
5 years, 2 months ago (2015-09-28 20:16:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369243002/20001
5 years, 2 months ago (2015-09-28 21:57:33 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 22:41:06 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e25b47b53a88620d1d22e7466e44574bfc4acc5b Cr-Commit-Position: refs/heads/master@{#351178}
5 years, 2 months ago (2015-09-28 22:42:44 UTC) #12
sdefresne
On 2015/09/28 at 20:15:24, smut wrote: > Time difference. It was like 5am for me ...
5 years, 2 months ago (2015-09-29 09:15:50 UTC) #13
smut
5 years, 2 months ago (2015-09-29 19:45:06 UTC) #14
Message was sent while issue was closed.
On 2015/09/29 09:15:50, sdefresne wrote:
> On 2015/09/28 at 20:15:24, smut wrote:
> > Time difference. It was like 5am for me and 8am when you re-sent. (:
> > 
> > Lgtm.
> 
> Sorry, the resend was just for adding justincohen@ as a second reviewer, not
> because I thought you were too slow, but because I wanted his input on running
> tests on iOS 7, 8 and 9. My goal was not to pressure you into quicker review,
> I'm well aware that you are in a different timezone.
> 
> I'm sorry that you felt it as such. I should have been clearer when adding
> justincohen@ as a secondary reviewer, and instead of just PTAL, I should have
> written something like "justincohen@ do you think it is a good idea to run the
> tests on all supported iOS versions or should I just run then on the two most
> recents one".
> 
> I'll try to do better, and again, thank you for your amazing job!

No, no. I was just kidding.

Powered by Google App Engine
This is Rietveld 408576698