[mac] Teach dump_syms to handle additional zerofill sections

src/common/mac/macho_reader.cc

Index: src/common/mac/macho_reader.cc
diff --git a/src/common/mac/macho_reader.cc b/src/common/mac/macho_reader.cc
index 9fcb58e35c2c1dea05f142702cb0160bf8918869..0358f97c5383addef4150be6a2b6c8e129c4d89d 100644
--- a/src/common/mac/macho_reader.cc
+++ b/src/common/mac/macho_reader.cc
@@ -481,7 +481,7 @@ bool Reader::WalkSegmentSections(const Segment &segment,
       reporter_->SectionsMissing(segment.name);
       return false;
     }
-    if ((section.flags & SECTION_TYPE) == S_ZEROFILL) {
+    if ((section.flags & SECTION_TYPE) == S_ZEROFILL || (section.flags & SECTION_TYPE) == S_THREAD_LOCAL_ZEROFILL) {

[Mark Mentovai, 2015/09/28 17:59:20]

Don’t go past 80 columns. Break the line after the ||. Alternatively, this is
also two lines and may be slightly more readable:

  const uint32_t section_type = section.flags & SECTION_TYPE;
  if (section_type == S_ZEROFILL || section_type == S_THREAD_LOCAL_ZEROFILL) {

You may also want to include S_GB_ZEROFILL here.

Reference:
https://chromium.googlesource.com/crashpad/crashpad/+/master/snapshot/mac/mac...

       // Zero-fill sections have a size, but no contents.
       section.contents.start = section.contents.end = NULL;
     } else if (segment.contents.start == NULL &&