Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: runtime/vm/intermediate_language.h

Issue 136923004: Ensure that MaterializeObject has relaxed RequiredInputRepresentation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
diff --git a/runtime/vm/intermediate_language.h b/runtime/vm/intermediate_language.h
index 33320f3451dd78a8379087ac98c4ce1d3ef24514..b3bbd0b9fd26dad70466ee2b4c2d75e74e60c04e 100644
--- a/runtime/vm/intermediate_language.h
+++ b/runtime/vm/intermediate_language.h
@@ -4026,6 +4026,16 @@ class MaterializeObjectInstr : public Definition {
return (*values_)[i];
}
+ // SelectRepresentations pass is run once more while MaterializeObject
+ // instructions are still in the graph. To avoid any redundant boxing
+ // operations inserted by that pass we should indicate that this
+ // instruction can cope with any representation as it is essentially
+ // an environment use.
+ virtual Representation RequiredInputRepresentation(intptr_t idx) const {
+ ASSERT(0 <= idx && idx < InputCount());
+ return kNoRepresentation;
+ }
+
virtual bool CanDeoptimize() const { return false; }
virtual EffectSet Effects() const { return EffectSet::None(); }
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698