Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1369213004: Revert of Add crash_service to Telemetry's isolates. (Closed)

Created:
5 years, 2 months ago by jwd
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, telemetry-reviews_chromium.org, ghost stip (do not use), jbudorick, pkotwicz, agrieve
Base URL:
https://chromium.googlesource.com/chromium/src.git@fck
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add crash_service to Telemetry's isolates. (patchset #12 id:340001 of https://codereview.chromium.org/1361523003/ ) Reason for revert: Seems to be causing failures on linux test bots https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/31890/steps/telemetry_gpu_unittests/logs/stdio Original issue's description: > Add crash_service to Telemetry's isolates. > > Switch to using binary_manager for the crash_service executable, > eliminating downloads of this binary from cloud storage. (A follow-on > CL will likely forbid the bots from downloading this and other > executables from cloud storage entirely, rather than continuing to use > this as a fallback path.) > > Telemetry's isolates are currently specified fairly differently for > the GYP and GN builds; other CLs underway will unify their > specification more. > > Follow up CL's will be needed to add the client config to gpu's tests. > > authors=kbr@,aiolos@ > > BUG=466877 > > Committed: https://crrev.com/6bdfb7dfb3ce2e571697629895089cffc42b48e6 > Cr-Commit-Position: refs/heads/master@{#351196} > > Committed: https://crrev.com/70c5d0c0e2ff03c3b6cef0bdce391f93c35d218a > Cr-Commit-Position: refs/heads/master@{#351803} TBR=phajdan.jr@chromium.org,dpranke@chromium.org,kbr@chromium.org,maruel@chromium.org,piman@chromium.org,aiolos@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466877 Committed: https://crrev.com/8608d47b147fd71d1f861991cdebedcb97cb63d1 Cr-Commit-Position: refs/heads/master@{#351815}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -191 lines) Patch
M chrome/chrome_tests.gypi View 2 chunks +0 lines, -18 lines 0 comments Download
D chrome/telemetry.isolate View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/telemetry_binary_manager.isolate View 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/telemetry_chrome_test.isolate View 1 chunk +1 line, -1 line 0 comments Download
D chrome/telemetry_gpu_unittests.isolate View 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/test/BUILD.gn View 3 chunks +12 lines, -16 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +13 lines, -0 lines 0 comments Download
A content/telemetry.isolate View 1 chunk +34 lines, -0 lines 0 comments Download
A content/telemetry_gpu_unittests.isolate View 1 chunk +28 lines, -0 lines 0 comments Download
M content/test/gpu/run_gpu_test.py View 1 chunk +1 line, -4 lines 0 comments Download
M content/test/gpu/run_unittests.py View 1 chunk +3 lines, -7 lines 0 comments Download
D tools/perf/core/binary_dependencies.json View 1 chunk +0 lines, -15 lines 0 comments Download
M tools/perf/core/project_config.py View 1 chunk +8 lines, -12 lines 0 comments Download
M tools/telemetry/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
M tools/telemetry/catapult_base/dependency_manager/dependency_manager.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/internal/binary_dependencies.json View 1 chunk +2 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jwd
Created Revert of Add crash_service to Telemetry's isolates.
5 years, 2 months ago (2015-10-01 15:58:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369213004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369213004/1
5 years, 2 months ago (2015-10-01 15:58:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-01 16:02:12 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 16:05:10 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8608d47b147fd71d1f861991cdebedcb97cb63d1
Cr-Commit-Position: refs/heads/master@{#351815}

Powered by Google App Engine
This is Rietveld 408576698