Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSImageValue.cpp

Issue 1369213002: Revert of Replace RawPtr with RefPtr on StylePendingImage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2008 Apple Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 10 matching lines...) Expand all
21 #include "config.h" 21 #include "config.h"
22 #include "core/css/CSSImageValue.h" 22 #include "core/css/CSSImageValue.h"
23 23
24 #include "core/css/CSSMarkup.h" 24 #include "core/css/CSSMarkup.h"
25 #include "core/dom/Document.h" 25 #include "core/dom/Document.h"
26 #include "core/fetch/FetchInitiatorTypeNames.h" 26 #include "core/fetch/FetchInitiatorTypeNames.h"
27 #include "core/fetch/FetchRequest.h" 27 #include "core/fetch/FetchRequest.h"
28 #include "core/fetch/ImageResource.h" 28 #include "core/fetch/ImageResource.h"
29 #include "core/loader/MixedContentChecker.h" 29 #include "core/loader/MixedContentChecker.h"
30 #include "core/style/StyleFetchedImage.h" 30 #include "core/style/StyleFetchedImage.h"
31 #include "core/style/StylePendingImage.h"
31 #include "platform/weborigin/KURL.h" 32 #include "platform/weborigin/KURL.h"
32 #include "platform/weborigin/SecurityPolicy.h" 33 #include "platform/weborigin/SecurityPolicy.h"
33 34
34 namespace blink { 35 namespace blink {
35 36
36 CSSImageValue::CSSImageValue(const AtomicString& rawValue, const KURL& url, Styl eImage* image) 37 CSSImageValue::CSSImageValue(const AtomicString& rawValue, const KURL& url, Styl eImage* image)
37 : CSSValue(ImageClass) 38 : CSSValue(ImageClass)
38 , m_relativeURL(rawValue) 39 , m_relativeURL(rawValue)
39 , m_absoluteURL(url.string()) 40 , m_absoluteURL(url.string())
40 , m_isCachePending(!image) 41 , m_image(image)
41 , m_cachedImage(image) 42 , m_accessedImage(image)
42 { 43 {
43 } 44 }
44 45
45 CSSImageValue::~CSSImageValue() 46 CSSImageValue::~CSSImageValue()
46 { 47 {
47 } 48 }
48 49
49 StyleFetchedImage* CSSImageValue::cacheImage(Document* document, const ResourceL oaderOptions& options) 50 StyleImage* CSSImageValue::cachedOrPendingImage()
51 {
52 if (!m_image)
53 m_image = StylePendingImage::create(this);
54
55 return m_image.get();
56 }
57
58 StyleFetchedImage* CSSImageValue::cachedImage(Document* document, const Resource LoaderOptions& options)
50 { 59 {
51 ASSERT(document); 60 ASSERT(document);
52 61
53 if (m_isCachePending) { 62 if (!m_accessedImage) {
54 m_isCachePending = false; 63 m_accessedImage = true;
55 64
56 FetchRequest request(ResourceRequest(m_absoluteURL), m_initiatorName.isE mpty() ? FetchInitiatorTypeNames::css : m_initiatorName, options); 65 FetchRequest request(ResourceRequest(m_absoluteURL), m_initiatorName.isE mpty() ? FetchInitiatorTypeNames::css : m_initiatorName, options);
57 request.mutableResourceRequest().setHTTPReferrer(SecurityPolicy::generat eReferrer(m_referrer.referrerPolicy, request.url(), m_referrer.referrer)); 66 request.mutableResourceRequest().setHTTPReferrer(SecurityPolicy::generat eReferrer(m_referrer.referrerPolicy, request.url(), m_referrer.referrer));
58 67
59 if (options.corsEnabled == IsCORSEnabled) 68 if (options.corsEnabled == IsCORSEnabled)
60 request.setCrossOriginAccessControl(document->securityOrigin(), opti ons.allowCredentials, options.credentialsRequested); 69 request.setCrossOriginAccessControl(document->securityOrigin(), opti ons.allowCredentials, options.credentialsRequested);
61 70
62 if (ResourcePtr<ImageResource> cachedImage = ImageResource::fetch(reques t, document->fetcher())) 71 if (ResourcePtr<ImageResource> cachedImage = ImageResource::fetch(reques t, document->fetcher()))
63 m_cachedImage = StyleFetchedImage::create(cachedImage.get(), documen t); 72 m_image = StyleFetchedImage::create(cachedImage.get(), document);
64 } 73 }
65 74
66 return (m_cachedImage && m_cachedImage->isImageResource()) ? toStyleFetchedI mage(m_cachedImage) : nullptr; 75 return (m_image && m_image->isImageResource()) ? toStyleFetchedImage(m_image ) : nullptr;
67 } 76 }
68 77
69 void CSSImageValue::restoreCachedResourceIfNeeded(Document& document) 78 void CSSImageValue::restoreCachedResourceIfNeeded(Document& document)
70 { 79 {
71 if (m_isCachePending || !m_cachedImage->isImageResource() || !document.fetch er()) 80 if (!m_accessedImage || !m_image->isImageResource() || !document.fetcher())
72 return; 81 return;
73 if (document.fetcher()->cachedResource(KURL(ParsedURLString, m_absoluteURL)) ) 82 if (document.fetcher()->cachedResource(KURL(ParsedURLString, m_absoluteURL)) )
74 return; 83 return;
75 84
76 ImageResource* resource = m_cachedImage->cachedImage(); 85 ImageResource* resource = m_image->cachedImage();
77 if (!resource) 86 if (!resource)
78 return; 87 return;
79 88
80 FetchRequest request(ResourceRequest(m_absoluteURL), m_initiatorName.isEmpty () ? FetchInitiatorTypeNames::css : m_initiatorName, resource->options()); 89 FetchRequest request(ResourceRequest(m_absoluteURL), m_initiatorName.isEmpty () ? FetchInitiatorTypeNames::css : m_initiatorName, resource->options());
81 MixedContentChecker::shouldBlockFetch(document.frame(), resource->lastResour ceRequest(), 90 MixedContentChecker::shouldBlockFetch(document.frame(), resource->lastResour ceRequest(),
82 resource->lastResourceRequest().url(), MixedContentChecker::SendReport); 91 resource->lastResourceRequest().url(), MixedContentChecker::SendReport);
83 document.fetcher()->requestLoadStarted(resource, request, ResourceFetcher::R esourceLoadingFromCache); 92 document.fetcher()->requestLoadStarted(resource, request, ResourceFetcher::R esourceLoadingFromCache);
84 } 93 }
85 94
86 bool CSSImageValue::hasFailedOrCanceledSubresources() const 95 bool CSSImageValue::hasFailedOrCanceledSubresources() const
87 { 96 {
88 if (!m_cachedImage || !m_cachedImage->isImageResource()) 97 if (!m_image || !m_image->isImageResource())
89 return false; 98 return false;
90 if (Resource* cachedResource = toStyleFetchedImage(m_cachedImage)->cachedIma ge()) 99 if (Resource* cachedResource = toStyleFetchedImage(m_image)->cachedImage())
91 return cachedResource->loadFailedOrCanceled(); 100 return cachedResource->loadFailedOrCanceled();
92 return true; 101 return true;
93 } 102 }
94 103
95 bool CSSImageValue::equals(const CSSImageValue& other) const 104 bool CSSImageValue::equals(const CSSImageValue& other) const
96 { 105 {
97 return m_absoluteURL == other.m_absoluteURL; 106 return m_absoluteURL == other.m_absoluteURL;
98 } 107 }
99 108
100 String CSSImageValue::customCSSText() const 109 String CSSImageValue::customCSSText() const
101 { 110 {
102 // TODO(nainar): Serialise with quotation marks to match spec: https://draft s.csswg.org/cssom/#serialize-a-url 111 // TODO(nainar): Serialise with quotation marks to match spec: https://draft s.csswg.org/cssom/#serialize-a-url
103 return "url(" + quoteCSSURLIfNeeded(serializeStringWithoutQuotations(m_relat iveURL)) + ")"; 112 return "url(" + quoteCSSURLIfNeeded(serializeStringWithoutQuotations(m_relat iveURL)) + ")";
104 } 113 }
105 114
106 bool CSSImageValue::knownToBeOpaque(const LayoutObject* layoutObject) const 115 bool CSSImageValue::knownToBeOpaque(const LayoutObject* layoutObject) const
107 { 116 {
108 return m_cachedImage ? m_cachedImage->knownToBeOpaque(layoutObject) : false; 117 return m_image ? m_image->knownToBeOpaque(layoutObject) : false;
109 } 118 }
110 119
111 DEFINE_TRACE_AFTER_DISPATCH(CSSImageValue) 120 DEFINE_TRACE_AFTER_DISPATCH(CSSImageValue)
112 { 121 {
113 visitor->trace(m_cachedImage); 122 visitor->trace(m_image);
114 CSSValue::traceAfterDispatch(visitor); 123 CSSValue::traceAfterDispatch(visitor);
115 } 124 }
116 125
117 void CSSImageValue::reResolveURL(const Document& document) 126 void CSSImageValue::reResolveURL(const Document& document)
118 { 127 {
119 KURL url = document.completeURL(m_relativeURL); 128 KURL url = document.completeURL(m_relativeURL);
120 AtomicString urlString(url.string()); 129 AtomicString urlString(url.string());
121 if (urlString == m_absoluteURL) 130 if (urlString == m_absoluteURL)
122 return; 131 return;
123 m_absoluteURL = urlString; 132 m_absoluteURL = urlString;
124 m_isCachePending = true; 133 m_accessedImage = false;
125 m_cachedImage.clear(); 134 m_image.clear();
126 } 135 }
127 136
128 } // namespace blink 137 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698