Issue 13692002: Update calls to scoped_array<T>::reset(NULL) to use the no-arg version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13692002: Update calls to scoped_array<T>::reset(NULL) to use the no-arg version. (Closed)

Created:
7 years, 8 months ago by dcheng

Modified:
7 years, 8 months ago

Reviewers:
ddorwin

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, gavinp+memory_chromium.org, garykac+watch_chromium.org, feature-media-reviews_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, erikwright+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update calls to scoped_array<T>::reset(NULL) to use the no-arg version. scoped_ptr<T[]>, which will replace scoped_array<T>, does not support passing NULL as an explicit argument to reset(). BUG=171118 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192506

Patch Set 1 #

Patch Set 2 : Prepare for landing! #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	media/audio/win/waveout_output_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dcheng

Please review this as if the only change was in media/. The other changes are ...

7 years, 8 months ago (2013-04-05 01:48:46 UTC) #1

dcheng

7 years, 8 months ago (2013-04-05 04:34:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r192506 (presubmit successful).

Expand Messages | Collapse Messages