Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Issue 1369133002: Remove unused macros from config.h (Closed)

Created:
5 years, 2 months ago by lgombos
Modified:
5 years, 2 months ago
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused macros from config.h. HAVE_SIGNAL_H, HAVE_TM_GMTOFF, HAVE_TM_ZONE and HAVE_TIMEGM macros are no longer used; so remove them. HAVE_SYS_TIME_H has been only used in DateMath.cpp, but in other parts of blink we use !OS(WIN) to guard including <sys/time.h>, so lets do the same in DateMath.cpp as well. Committed: https://crrev.com/7cdc11ff21e6c0f6068510bf72c65ac125a73412 Cr-Commit-Position: refs/heads/master@{#351079}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M third_party/WebKit/Source/config.h View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/wtf/DateMath.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
lgombos
Trivial cleanup. The less global macros we have in blink, the better.
5 years, 2 months ago (2015-09-28 01:07:12 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-09-28 11:31:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369133002/1
5 years, 2 months ago (2015-09-28 14:41:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 16:13:13 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 16:14:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7cdc11ff21e6c0f6068510bf72c65ac125a73412
Cr-Commit-Position: refs/heads/master@{#351079}

Powered by Google App Engine
This is Rietveld 408576698