src/objects.h - Issue 1369123002: [Interpreter] Add interpreter support for compare ops and ToBoolean.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.h

Issue 1369123002: [Interpreter] Add interpreter support for compare ops and ToBoolean. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Incorporate bmeurer's comments (https://codereview.chromium.org/1369123002/#msg4). Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.h

diff --git a/src/objects.h b/src/objects.h

index 6838f275b9643089032532046f816e5335797637..40b346cda6c2565364d703a093f4fbe8564c8226 100644

--- a/src/objects.h

+++ b/src/objects.h

@@ -815,7 +815,7 @@ enum CompareResult {

enum class ComparisonResult {

kLessThan, // x < y

kEqual, // x = y

- kGreaterThan, // x > x

+ kGreaterThan, // x > y

kUndefined // at least one of x or y was undefined or NaN

};

« no previous file with comments | « src/interpreter/interpreter.cc ('k') | src/runtime/runtime.h » ('j') | src/runtime/runtime-interpreter.cc » ('J')