[Interpreter] Add interpreter support for compare ops and ToBoolean.

src/runtime/runtime-interpreter.cc

+// Copyright 2015 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "src/runtime/runtime-utils.h"
+
+#include "src/arguments.h"
+#include "src/isolate-inl.h"
+
+namespace v8 {
+namespace internal {
+
+
+static Object* ComparisonHelper(Isolate* isolate, ComparisonResult expected,

[Benedikt Meurer, 2015/09/28 09:05:23]

Please don't write your own wrapper, but use Object::LessThan and friends, which
do the right thing.

[oth, 2015/09/28 10:23:02]

Done.

+                                Handle<Object> x, Handle<Object> y,
+                                bool negate_result = false) {
+  Maybe<ComparisonResult> result = Object::Compare(x, y, Strength::WEAK);
+  if (!result.IsJust()) return isolate->heap()->exception();
+  ComparisonResult r = result.FromJust();
+  if (r == ComparisonResult::kUndefined) {
+    DCHECK(x->IsNaN() || y->IsNaN());
+    return isolate->heap()->false_value();
+  }
+  return isolate->heap()->ToBoolean((r == expected) ^ negate_result);
+}
+
+
+RUNTIME_FUNCTION(Runtime_InterpreterEquals) {
+  HandleScope scope(isolate);
+  DCHECK_EQ(2, args.length());
+  CONVERT_ARG_HANDLE_CHECKED(Object, x, 0);
+  CONVERT_ARG_HANDLE_CHECKED(Object, y, 1);
+  return ComparisonHelper(isolate, ComparisonResult::kEqual, x, y);

[Benedikt Meurer, 2015/09/28 09:05:23]

Equals and NotEquals cannot use Compare; you need to use Object::Equals instead
(which implements abstract equality).

[oth, 2015/09/28 10:23:02]

Done.

+}
+
+
+RUNTIME_FUNCTION(Runtime_InterpreterNotEquals) {
+  HandleScope scope(isolate);
+  DCHECK_EQ(2, args.length());
+  CONVERT_ARG_HANDLE_CHECKED(Object, x, 0);
+  CONVERT_ARG_HANDLE_CHECKED(Object, y, 1);
+  return ComparisonHelper(isolate, ComparisonResult::kEqual, x, y, true);
+}
+
+
+RUNTIME_FUNCTION(Runtime_InterpreterLessThan) {
+  HandleScope scope(isolate);
+  DCHECK_EQ(2, args.length());
+  CONVERT_ARG_HANDLE_CHECKED(Object, x, 0);
+  CONVERT_ARG_HANDLE_CHECKED(Object, y, 1);
+  return ComparisonHelper(isolate, ComparisonResult::kLessThan, x, y);
+}
+
+
+RUNTIME_FUNCTION(Runtime_InterpreterGreaterThan) {
+  HandleScope scope(isolate);
+  DCHECK_EQ(2, args.length());
+  CONVERT_ARG_HANDLE_CHECKED(Object, x, 0);
+  CONVERT_ARG_HANDLE_CHECKED(Object, y, 1);
+  return ComparisonHelper(isolate, ComparisonResult::kGreaterThan, x, y);
+}
+
+
+RUNTIME_FUNCTION(Runtime_InterpreterLessThanEqual) {
+  HandleScope scope(isolate);
+  DCHECK_EQ(2, args.length());
+  CONVERT_ARG_HANDLE_CHECKED(Object, x, 0);
+  CONVERT_ARG_HANDLE_CHECKED(Object, y, 1);
+  return ComparisonHelper(isolate, ComparisonResult::kGreaterThan, x, y, true);
+}
+
+
+RUNTIME_FUNCTION(Runtime_InterpreterGreaterThanEqual) {
+  HandleScope scope(isolate);
+  DCHECK_EQ(2, args.length());
+  CONVERT_ARG_HANDLE_CHECKED(Object, x, 0);
+  CONVERT_ARG_HANDLE_CHECKED(Object, y, 1);
+  return ComparisonHelper(isolate, ComparisonResult::kLessThan, x, y, true);
+}
+
+
+RUNTIME_FUNCTION(Runtime_InterpreterStrictEquals) {
+  SealHandleScope scope(isolate);
+  DCHECK_EQ(2, args.length());
+  CONVERT_ARG_CHECKED(Object, x, 0);
+  CONVERT_ARG_CHECKED(Object, y, 1);
+  return isolate->heap()->ToBoolean(x->StrictEquals(y));
+}
+
+
+RUNTIME_FUNCTION(Runtime_InterpreterStrictNotEquals) {
+  SealHandleScope scope(isolate);
+  DCHECK_EQ(2, args.length());
+  CONVERT_ARG_CHECKED(Object, x, 0);
+  CONVERT_ARG_CHECKED(Object, y, 1);
+  return isolate->heap()->ToBoolean(!x->StrictEquals(y));
+}
+
+
+RUNTIME_FUNCTION(Runtime_InterpreterCastToBoolean) {
+  SealHandleScope scope(isolate);
+  DCHECK_EQ(1, args.length());
+  CONVERT_ARG_CHECKED(Object, x, 0);
+  return isolate->heap()->ToBoolean(x->BooleanValue());
+}
+
+
+}  // namespace internal
+}  // namespace v8