[Interpreter] Add interpreter support for compare ops and ToBoolean.

src/interpreter/interpreter.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/interpreter.h"
 
 #include "src/code-factory.h"
 #include "src/compiler.h"
 #include "src/compiler/interpreter-assembler.h"
 #include "src/factory.h"
@@ skipping 276 matching lines @@
   // operations, instead of calling builtins directly.
   Node* reg_index = __ BytecodeOperandReg(0);
   Node* lhs = __ LoadRegister(reg_index);
   Node* rhs = __ GetAccumulator();
   Node* result = __ CallRuntime(function_id, lhs, rhs);
   __ SetAccumulator(result);
   __ Dispatch();
 }
 
 
-void Interpreter::DoCompareOp(Token::Value op,
-                              compiler::InterpreterAssembler* assembler) {
-  // TODO(oth): placeholder until compare path fixed.
-  // The accumulator should be set to true on success (or false otherwise)
-  // by the comparisons so it can be used for conditional jumps.
-  DoLdaTrue(assembler);
-}
-
-
 // Add <src>
 //
 // Add register <src> to accumulator.
 void Interpreter::DoAdd(compiler::InterpreterAssembler* assembler) {
   DoBinaryOp(Runtime::kAdd, assembler);
 }
 
 
 // Sub <src>
 //
@@ skipping 40 matching lines @@
   Node* result = __ CallJS(function, first_arg, args_count);
   __ SetAccumulator(result);
   __ Dispatch();
 }
 
 
 // TestEqual <src>
 //
 // Test if the value in the <src> register equals the accumulator.
 void Interpreter::DoTestEqual(compiler::InterpreterAssembler* assembler) {
-  DoCompareOp(Token::Value::EQ, assembler);
+  DoBinaryOp(Runtime::kInterpreterEquals, assembler);
 }
 
 
 // TestNotEqual <src>
 //
 // Test if the value in the <src> register is not equal to the accumulator.
 void Interpreter::DoTestNotEqual(compiler::InterpreterAssembler* assembler) {
-  DoCompareOp(Token::Value::NE, assembler);
+  DoBinaryOp(Runtime::kInterpreterNotEquals, assembler);
 }
 
 
 // TestEqualStrict <src>
 //
 // Test if the value in the <src> register is strictly equal to the accumulator.
 void Interpreter::DoTestEqualStrict(compiler::InterpreterAssembler* assembler) {
-  DoCompareOp(Token::Value::EQ_STRICT, assembler);
+  DoBinaryOp(Runtime::kInterpreterStrictEquals, assembler);
 }
 
 
 // TestNotEqualStrict <src>
 //
 // Test if the value in the <src> register is not strictly equal to the
 // accumulator.
 void Interpreter::DoTestNotEqualStrict(
     compiler::InterpreterAssembler* assembler) {
-  DoCompareOp(Token::Value::NE_STRICT, assembler);
+  DoBinaryOp(Runtime::kInterpreterStrictNotEquals, assembler);
 }
 
 
 // TestLessThan <src>
 //
 // Test if the value in the <src> register is less than the accumulator.
 void Interpreter::DoTestLessThan(compiler::InterpreterAssembler* assembler) {
-  DoCompareOp(Token::Value::LT, assembler);
+  DoBinaryOp(Runtime::kInterpreterLessThan, assembler);
 }
 
 
 // TestGreaterThan <src>
 //
 // Test if the value in the <src> register is greater than the accumulator.
 void Interpreter::DoTestGreaterThan(compiler::InterpreterAssembler* assembler) {
-  DoCompareOp(Token::Value::GT, assembler);
+  DoBinaryOp(Runtime::kInterpreterGreaterThan, assembler);
 }
 
 
-// TestLessThanEqual <src>
+// TestLessThanOrEqual <src>
 //
 // Test if the value in the <src> register is less than or equal to the
 // accumulator.
-void Interpreter::DoTestLessThanEqual(
+void Interpreter::DoTestLessThanOrEqual(
     compiler::InterpreterAssembler* assembler) {
-  DoCompareOp(Token::Value::LTE, assembler);
+  DoBinaryOp(Runtime::kInterpreterLessThanOrEqual, assembler);
 }
 
 
-// TestGreaterThanEqual <src>
+// TestGreaterThanOrEqual <src>
 //
 // Test if the value in the <src> register is greater than or equal to the
 // accumulator.
-void Interpreter::DoTestGreaterThanEqual(
+void Interpreter::DoTestGreaterThanOrEqual(
     compiler::InterpreterAssembler* assembler) {
-  DoCompareOp(Token::Value::GTE, assembler);
+  DoBinaryOp(Runtime::kInterpreterGreaterThanOrEqual, assembler);
 }
 
 
 // TestIn <src>
 //
-// Test if the value in the <src> register is in the collection referenced
-// by the accumulator.
+// Test if the object referenced by the register operand is a property of the
+// object referenced by the accumulator.
 void Interpreter::DoTestIn(compiler::InterpreterAssembler* assembler) {
-  DoCompareOp(Token::Value::IN, assembler);
+  DoBinaryOp(Runtime::kHasProperty, assembler);
 }
 
 
 // TestInstanceOf <src>
 //
 // Test if the object referenced by the <src> register is an an instance of type
 // referenced by the accumulator.
 void Interpreter::DoTestInstanceOf(compiler::InterpreterAssembler* assembler) {
-  DoCompareOp(Token::Value::INSTANCEOF, assembler);
+  DoBinaryOp(Runtime::kInstanceOf, assembler);
 }
 
 
 // ToBoolean
 //
 // Cast the object referenced by the accumulator to a boolean.
 void Interpreter::DoToBoolean(compiler::InterpreterAssembler* assembler) {
   // TODO(oth): The next CL for test operations has interpreter specific
   // runtime calls. This looks like another candidate.
   __ Dispatch();
@@ skipping 78 matching lines @@
 //
 // Return the value in register 0.
 void Interpreter::DoReturn(compiler::InterpreterAssembler* assembler) {
   __ Return();
 }
 
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8