DevTools: merge excluded folder manager into isolated file system.

DevTools: merge excluded folder manager into isolated file system.

BUG=529471
Committed: https://crrev.com/427d4a566e68f4e2c3be757a666ce2855a23de01
Cr-Commit-Position: refs/heads/master@{#351203}

[pfeldman, 2015-09-25 22:56:46]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2015-09-26 01:46:41]

https://codereview.chromium.org/1369063002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector/file-system-project.html (right):

https://codereview.chromium.org/1369063002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/file-system-project.html:154: var
isolatedFileSystem =
WebInspector.isolatedFileSystemManager.fileSystem("/var/www2");
not used

https://codereview.chromium.org/1369063002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/file-system-project.html:161: var
isolatedFileSystem =
WebInspector.isolatedFileSystemManager.fileSystem("/var/www3");
ditto

https://codereview.chromium.org/1369063002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/bindings/FileSystemWorkspaceBinding.js
(right):

https://codereview.chromium.org/1369063002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/FileSystemWorkspaceBinding.js:518:
this._fileSystem.addExcludedFolder(path);
Why does this go through ProjectDelegate, while settings dialog operates on
IsolatedFileSystem directly? I think we don't need extra indirection.

https://codereview.chromium.org/1369063002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystem.js
(right):

https://codereview.chromium.org/1369063002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystem.js:44:
this._excludedFolders = this._excludedFoldersSetting.get()[path] || [];
Note that you modify setting value in place with any operation on
_excludedFolders.

[dgozman, 2015-09-26 02:21:31]

lgtm, but please follow up on projectdelegate inderection

[pfeldman, 2015-09-27 03:10:47]

On 2015/09/26 02:21:31, dgozman wrote:
> lgtm, but please follow up on projectdelegate inderection

I can do that, but it is somewhat unrelated to this change.

[pfeldman, 2015-09-28 17:37:16]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2015-09-28 17:37:16]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1369063002/#ps20001
(title: "rebaselined")

[commit-bot: I haz the power, 2015-09-28 17:37:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1369063002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1369063002/20001

[commit-bot: I haz the power, 2015-09-28 17:42:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 17:42:55]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pfeldman, 2015-09-28 22:15:28]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2015-09-28 22:15:28]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1369063002/#ps40001
(title: "rebaselined")

[commit-bot: I haz the power, 2015-09-28 22:18:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1369063002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1369063002/40001

[commit-bot: I haz the power, 2015-09-28 23:44:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-28 23:45:58]

Patchset 3 (id:??) landed as
https://crrev.com/427d4a566e68f4e2c3be757a666ce2855a23de01
Cr-Commit-Position: refs/heads/master@{#351203}