Issue 136903004: Changing from opacity less than 1 to opacity 1 should not trigger layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136903004: Changing from opacity less than 1 to opacity 1 should not trigger layout (Closed)

Created:
6 years, 11 months ago by esprehn

Modified:
6 years, 11 months ago

Reviewers:
leviw_travelin_and_unemployed, shawnsingh, Ian Vollick, abarth-chromium, ZZZDONOTUSEMEZZZ, ojan, Julien - ping for review

CC:
blink-reviews, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Changing from opacity less than 1 to opacity 1 should not trigger layout RenderStyle::diff would always return StyleDifferenceLayout when adding or removing an opacity even though layout is only required if doing so would change if the layer is a stacking context. See: http://www.w3.org/TR/css3-color/#transparency http://www.w3.org/TR/CSS21/zindex.html BUG=334033 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165021

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -6 lines)			Patch
A	LayoutTests/fast/layers/opacity-change-stacking-context.html	View	1 chunk	+25 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/layers/opacity-change-stacking-context-expected.txt	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	Source/core/rendering/style/RenderStyle.cpp	View	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 7 (0 generated)

abarth-chromium

I'm not sure I'm really the best person to review this CL, but it LGTM ...

6 years, 11 months ago (2014-01-13 23:08:58 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/136903004/1

6 years, 11 months ago (2014-01-14 00:05:23 UTC) #6

Message was sent while issue was closed.

Change committed as 165021