Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1340)

Unified Diff: media/cast/logging/logging_defines.cc

Issue 136903003: cast: Wire upp logging to be sent over RTCP between receiver and sender. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/logging/logging_defines.cc
diff --git a/media/cast/logging/logging_defines.cc b/media/cast/logging/logging_defines.cc
index 16314714c1640bf888a4e62e6edaf092c171c1a6..6a21be319a96abe4d2768af921ca1b6db9a5e6a4 100644
--- a/media/cast/logging/logging_defines.cc
+++ b/media/cast/logging/logging_defines.cc
@@ -9,15 +9,21 @@
namespace media {
namespace cast {
-CastLoggingConfig::CastLoggingConfig()
- : enable_data_collection(false),
+CastLoggingConfig::CastLoggingConfig(bool sender)
mikhal1 2014/01/14 19:57:18 rename to is_sender for consistency
pwestin 2014/01/17 23:46:17 that wont compile
+ : is_sender(sender),
+ enable_data_collection(false),
enable_uma_stats(false),
enable_tracing(false) {}
CastLoggingConfig::~CastLoggingConfig() {}
-CastLoggingConfig GetDefaultCastLoggingConfig() {
- CastLoggingConfig config;
+CastLoggingConfig GetDefaultCastSenderLoggingConfig() {
+ CastLoggingConfig config(true);
+ return config;
+}
+
+CastLoggingConfig GetDefaultCastReceiverLoggingConfig() {
+ CastLoggingConfig config(false);
return config;
}
@@ -37,8 +43,10 @@ std::string CastLoggingToString(CastLoggingEvent event) {
return "AckReceived";
case(kRembBitrate):
return "RembBitrate";
- case(kAckSent):
- return "AckSent";
+ case(kAudioAckSent):
+ return "AudioAckSent";
+ case(kVideoAckSent):
+ return "VideoAckSent";
case(kLastEvent):
return "LastEvent";
case(kAudioFrameReceived):
@@ -69,8 +77,10 @@ std::string CastLoggingToString(CastLoggingEvent event) {
return "PacketSentToNetwork";
case(kPacketRetransmited):
return "PacketRetransmited";
- case(kPacketReceived):
- return "PacketReceived";
+ case(kAudioPacketReceived):
+ return "AudioPacketReceived";
+ case(kVideoPacketReceived):
+ return "VideoPacketReceived";
case(kDuplicatePacketReceived):
return "DuplicatePacketReceived";
default:
@@ -91,6 +101,9 @@ PacketEvent::~PacketEvent() {}
GenericEvent::GenericEvent() {}
GenericEvent::~GenericEvent() {}
+ReceiverRtcpEvent::ReceiverRtcpEvent() {}
+ReceiverRtcpEvent::~ReceiverRtcpEvent() {}
+
FrameLogStats::FrameLogStats()
: framerate_fps(0),
bitrate_kbps(0),

Powered by Google App Engine
This is Rietveld 408576698