src/IceInst.cpp - Issue 1368993004: Subzero: Improve usability of liveness-related tools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInst.cpp

Issue 1368993004: Subzero: Improve usability of liveness-related tools. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Code review changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInst.cpp

diff --git a/src/IceInst.cpp b/src/IceInst.cpp

index 656ac172f412fb179dc65e5a090a7840418b9d5b..4a5eb2f30433addd4672f02121b0829a0246d5b0 100644

--- a/src/IceInst.cpp

+++ b/src/IceInst.cpp

@@ -170,7 +170,7 @@ bool Inst::liveness(InstNumberT InstNumber, LivenessBV &Live,

if (Dest) {

SizeT VarNum = Liveness->getLiveIndex(Dest->getIndex());

if (Live[VarNum]) {

- if (!isDestNonKillable()) {

+ if (!isDestRedefined()) {

Live[VarNum] = false;

if (LiveBegin && Liveness->getRangeMask(Dest->getIndex())) {

LiveBegin->push_back(std::make_pair(VarNum, InstNumber));

« no previous file with comments | « src/IceInst.h ('k') | src/IceRegAlloc.h » ('j') | no next file with comments »