src/IceCfg.cpp - Issue 1368993004: Subzero: Improve usability of liveness-related tools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceCfg.cpp

Issue 1368993004: Subzero: Improve usability of liveness-related tools. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Code review changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceCfg.cpp

diff --git a/src/IceCfg.cpp b/src/IceCfg.cpp

index a72671e31f23d3491619af0a1702000ed9974852..eaebd1ea9b930894e6d8507abfcaa148d55a427b 100644

--- a/src/IceCfg.cpp

+++ b/src/IceCfg.cpp

@@ -617,7 +617,7 @@ bool Cfg::validateLiveness() const {

// the previous block, and if it is also assigned in the first

// instruction of this block, the adjacent live ranges get merged.

if (static_cast<class Inst *>(&Inst) != FirstInst &&

- !Inst.isDestNonKillable() &&

+ !Inst.isDestRedefined() &&

Dest->getLiveRange().containsValue(InstNumber - 1, IsDest))

Invalid = true;

if (Invalid) {

« no previous file with comments | « no previous file | src/IceCfgNode.h » ('j') | no next file with comments »