Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Unified Diff: src/heap/gc-idle-time-handler.h

Issue 1368983002: [heap] No leakage of gc-idle-time-handler.h outside of heap. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Drop obsolete forward declaration. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/gc-idle-time-handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/gc-idle-time-handler.h
diff --git a/src/heap/gc-idle-time-handler.h b/src/heap/gc-idle-time-handler.h
index 3f7f02d390a50d7ea2805b25853adc8504fd02fc..ce4aeee9ee3218ffbd967425d271ffe7352a29dd 100644
--- a/src/heap/gc-idle-time-handler.h
+++ b/src/heap/gc-idle-time-handler.h
@@ -63,7 +63,26 @@ class GCIdleTimeAction {
};
-class GCTracer;
+class GCIdleTimeHeapState {
+ public:
+ void Print();
+
+ int contexts_disposed;
+ double contexts_disposal_rate;
+ size_t size_of_objects;
+ bool incremental_marking_stopped;
+ bool sweeping_in_progress;
+ bool sweeping_completed;
+ bool has_low_allocation_rate;
+ size_t mark_compact_speed_in_bytes_per_ms;
+ size_t incremental_marking_speed_in_bytes_per_ms;
+ size_t final_incremental_mark_compact_speed_in_bytes_per_ms;
+ size_t scavenge_speed_in_bytes_per_ms;
+ size_t used_new_space_size;
+ size_t new_space_capacity;
+ size_t new_space_allocation_throughput_in_bytes_per_ms;
+};
+
// The idle time handler makes decisions about which garbage collection
// operations are executing during IdleNotification.
@@ -133,29 +152,10 @@ class GCIdleTimeHandler {
// ensure we don't keep scheduling idle tasks and making no progress.
static const int kMaxNoProgressIdleTimes = 10;
- class HeapState {
- public:
- void Print();
-
- int contexts_disposed;
- double contexts_disposal_rate;
- size_t size_of_objects;
- bool incremental_marking_stopped;
- bool sweeping_in_progress;
- bool sweeping_completed;
- bool has_low_allocation_rate;
- size_t mark_compact_speed_in_bytes_per_ms;
- size_t incremental_marking_speed_in_bytes_per_ms;
- size_t final_incremental_mark_compact_speed_in_bytes_per_ms;
- size_t scavenge_speed_in_bytes_per_ms;
- size_t used_new_space_size;
- size_t new_space_capacity;
- size_t new_space_allocation_throughput_in_bytes_per_ms;
- };
-
GCIdleTimeHandler() : idle_times_which_made_no_progress_(0) {}
- GCIdleTimeAction Compute(double idle_time_in_ms, HeapState heap_state);
+ GCIdleTimeAction Compute(double idle_time_in_ms,
+ GCIdleTimeHeapState heap_state);
void ResetNoProgressCounter() { idle_times_which_made_no_progress_ = 0; }
« no previous file with comments | « no previous file | src/heap/gc-idle-time-handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698