[turbofan] Check node input/use consistency for changed operators and new nodes.

src/compiler/node-properties.h

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_NODE_PROPERTIES_H_
 #define V8_COMPILER_NODE_PROPERTIES_H_
 
 #include "src/compiler/node.h"
 #include "src/types.h"
 
@@ skipping 80 matching lines @@
   // Replace all uses of {node} with the given replacement nodes. All occurring
   // use kinds need to be replaced, {NULL} is only valid if a use kind is
   // guaranteed not to exist.
   static void ReplaceUses(Node* node, Node* value, Node* effect = nullptr,
                           Node* success = nullptr, Node* exception = nullptr);
 
   // Safe wrapper to mutate the operator of a node. Checks that the node is
   // currently in a state that satisfies constraints of the new operator.
   static void ChangeOp(Node* node, const Operator* new_op);
 
+  // Verifies consistency of node inputs and uses:
+  // - node inputs should agree with the input count computed from
+  //   the node's operator.
+  // - effect inputs should have effect outputs.
+  // - control inputs should have control outputs.
+  // - frame state inputs should be frame states.
+  // - if the node has control uses, it should produce control.
+  // - if the node has effect uses, it should produce effect.
+  // - if the node has frame state uses, it must be a frame state.
+  static void Verify(Node* node);

[Michael Starzinger, 2015/09/25 08:16:45]

nit: This is not really a "miscellaneous mutator" I think, can we move it out of
this section into the "miscellaneous utilities" section below?

[Jarin, 2015/09/25 08:20:06]

Done.

+
   // ---------------------------------------------------------------------------
   // Miscellaneous utilities.
 
   static Node* FindProjection(Node* node, size_t projection_index);
 
   // Collect the branch-related projections from a node, such as IfTrue,
   // IfFalse, IfSuccess, IfException, IfValue and IfDefault.
   //  - Branch: [ IfTrue, IfFalse ]
   //  - Call  : [ IfSuccess, IfException ]
   //  - Switch: [ IfValue, ..., IfDefault ]
@@ skipping 17 matching lines @@
 
  private:
   static inline bool IsInputRange(Edge edge, int first, int count);
 };
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_NODE_PROPERTIES_H_