Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1368873002: X87: [turbofan] Call ArgumentsAccessStub to materialize arguments. (Closed)

Created:
5 years, 2 months ago by chunyang.dai
Modified:
5 years, 2 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Call ArgumentsAccessStub to materialize arguments. port 9b12ec9ac2aff2978d05df775ce621ba4d90cbe8 (r30919) original commit message: This lowers JSCreateArgument nodes to call the ArgumentsAccessStub for help with materializing arguments objects when possible. Along the way this changes the calling convention of said stub to take parameters in registers instead of on the stack. R=weiliang.lin@intel.com BUG= Committed: https://crrev.com/8322defdb9abea3e06d43770d261d884eeef4f96 Cr-Commit-Position: refs/heads/master@{#30923}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -102 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +13 lines, -19 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 12 chunks +97 lines, -83 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Weiliang
lgtm
5 years, 2 months ago (2015-09-25 02:38:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368873002/1
5 years, 2 months ago (2015-09-25 02:38:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 03:00:31 UTC) #4
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 03:00:52 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8322defdb9abea3e06d43770d261d884eeef4f96
Cr-Commit-Position: refs/heads/master@{#30923}

Powered by Google App Engine
This is Rietveld 408576698