Set SSL info when an HTTP auth dialog is triggered by direct navigation.

chrome/browser/ui/login/login_interstitial_delegate.cc

Index: chrome/browser/ui/login/login_interstitial_delegate.cc
diff --git a/chrome/browser/ui/login/login_interstitial_delegate.cc b/chrome/browser/ui/login/login_interstitial_delegate.cc
index bd487559a52b9b1eb6cdf8806476d17f18222f85..0109b9791af7d58cf4ff9c4b524b332aca55f4a6 100644
--- a/chrome/browser/ui/login/login_interstitial_delegate.cc
+++ b/chrome/browser/ui/login/login_interstitial_delegate.cc
@@ -3,6 +3,8 @@
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/login/login_interstitial_delegate.h"
+#include "content/public/browser/navigation_entry.h"
+#include "content/public/common/ssl_status.h"
 
 content::InterstitialPageDelegate::TypeID
     LoginInterstitialDelegate::kTypeForTesting =
@@ -11,8 +13,11 @@ content::InterstitialPageDelegate::TypeID
 LoginInterstitialDelegate::LoginInterstitialDelegate(
     content::WebContents* web_contents,
     const GURL& request_url,
+    const content::SSLStatus& ssl_status,
     base::Closure& callback)
-    : callback_(callback) {
+    : web_contents_(web_contents),
+      ssl_status_(ssl_status),
+      callback_(callback) {
   // The interstitial page owns us.
   content::InterstitialPage* interstitial_page =
       content::InterstitialPage::Create(web_contents,
@@ -46,3 +51,14 @@ std::string LoginInterstitialDelegate::GetHTMLContents() {
       "window.domAutomationController.send('1');"
       "</script></body></html>");
 }
+
+void LoginInterstitialDelegate::OverrideEntry(content::NavigationEntry* entry) {

[Charlie Reis, 2015/09/29 22:52:11]

I don't see a caller of this, and it looks like a dangerous method if used
incorrectly.  (It could easily lead to spoof attacks if the wrong entry is
passed in.)  Can we remove it?  If not, can we add some way to verify whether
the entry is the intended one, such as at least comparing against the
request_url?

+  entry->GetSSL().security_style = ssl_status_.security_style;
+  entry->GetSSL().cert_id = ssl_status_.cert_id;
+  entry->GetSSL().cert_status = ssl_status_.cert_status;
+  entry->GetSSL().security_bits = ssl_status_.security_bits;
+  entry->GetSSL().connection_status = ssl_status_.connection_status;
+  entry->GetSSL().content_status = ssl_status_.content_status;
+  entry->GetSSL().signed_certificate_timestamp_ids =
+      ssl_status_.signed_certificate_timestamp_ids;
+}