Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1850)

Unified Diff: content/browser/ssl/ssl_manager.h

Issue 1368863002: Set SSL info when an HTTP auth dialog is triggered by direct navigation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to creis' comments on the other CL. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/ssl/ssl_manager.h
diff --git a/content/browser/ssl/ssl_manager.h b/content/browser/ssl/ssl_manager.h
index 8128ee8e0491b2b2bce3ede602ddd4848781ba6d..88d09550c106ef94b311e5280ed2f1640c8a7313 100644
--- a/content/browser/ssl/ssl_manager.h
+++ b/content/browser/ssl/ssl_manager.h
@@ -27,6 +27,7 @@ class BrowserContext;
class NavigationEntryImpl;
class NavigationControllerImpl;
class SSLPolicy;
+struct SSLStatus;
struct LoadCommittedDetails;
struct LoadFromMemoryCacheDetails;
struct ResourceRedirectDetails;
@@ -57,6 +58,20 @@ class CONTENT_EXPORT SSLManager {
const net::SSLInfo& ssl_info,
bool fatal);
+ // Called before an HTTP basic auth dialog is displayed. Call this from the IO
+ // thread.
+ static void OnAuthDialog(int render_process_id,
+ int render_frame_id,
+ const content::SSLStatus& ssl_status,
+ bool is_main_frame);
+
+ // Called before an HTTP basic auth dialog is displayed. Call this from the UI
+ // thread.
+ static void OnAuthDialogOnUI(int render_process_id,
+ int render_frame_id,
+ const content::SSLStatus& ssl_status,
+ bool is_main_frame);
+
// Called when SSL state for a host or tab changes.
static void NotifySSLInternalStateChanged(BrowserContext* context);
@@ -86,6 +101,9 @@ class CONTENT_EXPORT SSLManager {
// notify the WebContents of an SSL state change if a change was
// actually made.
void UpdateEntry(NavigationEntryImpl* entry);
+ void UpdateEntry(const content::SSLStatus& ssl_status,
+ bool is_main_frame,
+ NavigationEntryImpl* entry);
// Notifies the WebContents that the SSL state changed.
void NotifyDidChangeVisibleSSLState();

Powered by Google App Engine
This is Rietveld 408576698