Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 1368833004: Revert of [heap] Move large object space selection into AllocateRaw. (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Move large object space selection into AllocateRaw. (patchset #2 id:20001 of https://codereview.chromium.org/1373523002/ ) Reason for revert: Breaks mac asan: http://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/2895 According to auto bisect Original issue's description: > [heap] Move large object space selection into AllocateRaw. > > BUG= > > Committed: https://crrev.com/e4f7ebb000432cc2011ecaaa71a69e2e60f416f0 > Cr-Commit-Position: refs/heads/master@{#30938} TBR=mlippautz@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/4c64573de1716e2cdbb4814b31f7d281cc529e2a Cr-Commit-Position: refs/heads/master@{#30948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -37 lines) Patch
M src/heap/heap.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 12 chunks +15 lines, -12 lines 0 comments Download
M src/heap/heap-inl.h View 3 chunks +16 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [heap] Move large object space selection into AllocateRaw.
5 years, 2 months ago (2015-09-25 16:10:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368833004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368833004/1
5 years, 2 months ago (2015-09-25 16:11:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 16:11:17 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 16:11:33 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c64573de1716e2cdbb4814b31f7d281cc529e2a
Cr-Commit-Position: refs/heads/master@{#30948}

Powered by Google App Engine
This is Rietveld 408576698