Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 136883006: make ignored-tests.txt specify full test name, not partial name (Closed)

Created:
6 years, 11 months ago by epoger
Modified:
6 years, 11 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com, robertphillips
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

make ignored-tests.txt specify full test name, not partial name BUG=skia:2022 Committed: http://code.google.com/p/skia/source/detail?r=13060

Patch Set 1 : change behavior and update results of original tests #

Patch Set 2 : update self-test to exercise new behavior #

Total comments: 3

Patch Set 3 : update real ignored-tests.txt file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -43 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M gm/gmmain.cpp View 1 8 chunks +11 lines, -14 lines 0 comments Download
M gm/tests/outputs/compared-against-empty-dir/output-expected/command_line View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-empty-dir/output-expected/json-summary.txt View 1 1 chunk +11 lines, -1 line 0 comments Download
A + gm/tests/outputs/compared-against-empty-dir/output-expected/missingExpectationsPath/565/selftest2.png View 1 Binary file 0 comments Download
A + gm/tests/outputs/compared-against-empty-dir/output-expected/missingExpectationsPath/8888/selftest2.png View 1 Binary file 0 comments Download
M gm/tests/outputs/compared-against-empty-dir/output-expected/stdout View 1 1 chunk +5 lines, -4 lines 0 comments Download
A + gm/tests/outputs/compared-against-empty-dir/output-expected/writePath/565/selftest2.png View 1 Binary file 0 comments Download
A + gm/tests/outputs/compared-against-empty-dir/output-expected/writePath/8888/selftest2.png View 1 Binary file 0 comments Download
M gm/tests/outputs/ignoring-one-test/output-expected/command_line View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/ignoring-one-test/output-expected/json-summary.txt View 1 3 chunks +15 lines, -1 line 0 comments Download
A + gm/tests/outputs/ignoring-one-test/output-expected/mismatchPath/565/selftest2.png View 1 Binary file 0 comments Download
A + gm/tests/outputs/ignoring-one-test/output-expected/mismatchPath/8888/selftest2.png View 1 Binary file 0 comments Download
M gm/tests/outputs/ignoring-one-test/output-expected/stdout View 1 1 chunk +5 lines, -4 lines 0 comments Download
A + gm/tests/outputs/ignoring-one-test/output-expected/writePath/565/selftest2.png View 1 Binary file 0 comments Download
A + gm/tests/outputs/ignoring-one-test/output-expected/writePath/8888/selftest2.png View 1 Binary file 0 comments Download
M gm/tests/run.sh View 1 4 chunks +26 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
epoger
as of patchset 2 (more work coming)... https://codereview.chromium.org/136883006/diff/150001/gm/tests/outputs/compared-against-empty-dir/output-expected/json-summary.txt File gm/tests/outputs/compared-against-empty-dir/output-expected/json-summary.txt (right): https://codereview.chromium.org/136883006/diff/150001/gm/tests/outputs/compared-against-empty-dir/output-expected/json-summary.txt#newcode9 gm/tests/outputs/compared-against-empty-dir/output-expected/json-summary.txt:9: "8888/selftest2.png" : ...
6 years, 11 months ago (2014-01-13 20:23:46 UTC) #1
epoger
Ready for review at patchset 3.
6 years, 11 months ago (2014-01-13 20:29:39 UTC) #2
bsalomon
lgtm, to the extent I understand.
6 years, 11 months ago (2014-01-13 21:52:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/136883006/250001
6 years, 11 months ago (2014-01-14 02:44:55 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 02:54:19 UTC) #5
Message was sent while issue was closed.
Change committed as 13060

Powered by Google App Engine
This is Rietveld 408576698