Location/size change notification when external rendering is enabled

webkit/media/android/webmediaplayer_android.cc

Index: webkit/media/android/webmediaplayer_android.cc
diff --git a/webkit/media/android/webmediaplayer_android.cc b/webkit/media/android/webmediaplayer_android.cc
index 5b00e5dbd3c31626a8eb0ff1563c1f33463dccee..8420af23401c149b2bf7c86a984c7f5ecbcc40bb 100644
--- a/webkit/media/android/webmediaplayer_android.cc
+++ b/webkit/media/android/webmediaplayer_android.cc
@@ -480,4 +480,22 @@ void WebMediaPlayerAndroid::UpdatePlayingState(bool is_playing) {
   is_playing_ = is_playing;
 }
 
+bool WebMediaPlayerAndroid::GetGeometryChange(gfx::RectF* rect) {
+  if (!video_weblayer_)
+    return false;
+
+  cc::Layer* layer = video_weblayer_->layer();
+  rect->set_size(layer->bounds());
+  while (layer) {
+    rect->Offset(layer->position().OffsetFromOrigin());
+    layer = layer->parent();
+  }
+
+  if (rect_ == *rect)

[scherkus (not reviewing), 2013/04/08 14:58:23]

based on your usage, |rect| appears to always be (0,0,0,0)

does this condition ever evaluate to true?

[wonsik, 2013/04/09 09:13:22]

|rect| represents the geometry of the video frame (offset and size). |rect_|
will contain the geometry information when it was last computed. It can differ
from (0,0,0,0) in most of cases. Perhaps I confused you with lack of comments..

+    return false;
+
+  rect_ = *rect;
+  return true;
+}
+
 }  // namespace webkit_media