Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: content/browser/android/media_player_manager_android.cc

Issue 13688004: Location/size change notification when external rendering is enabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Andrew's comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/media_player_manager_android.cc
diff --git a/content/browser/android/media_player_manager_android.cc b/content/browser/android/media_player_manager_android.cc
index ef650286e98e604102be1ff23d8b357a45741ef2..6d4bd3a54de87a9b4f5084318742fc817213825c 100644
--- a/content/browser/android/media_player_manager_android.cc
+++ b/content/browser/android/media_player_manager_android.cc
@@ -47,6 +47,8 @@ bool MediaPlayerManagerAndroid::OnMessageReceived(const IPC::Message& msg) {
DestroyAllMediaPlayers)
IPC_MESSAGE_HANDLER(MediaPlayerHostMsg_RequestExternalSurface,
OnRequestExternalSurface)
+ IPC_MESSAGE_HANDLER(MediaPlayerHostMsg_NotifyGeometryChange,
+ OnNotifyGeometryChange)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
return handled;
@@ -221,6 +223,16 @@ void MediaPlayerManagerAndroid::OnRequestExternalSurface(int player_id) {
}
}
+void MediaPlayerManagerAndroid::OnNotifyGeometryChange(int player_id,
+ const gfx::RectF& rect) {
+ if (web_contents_) {
palmer 2013/04/09 19:02:41 NIT: You could save a level of indentation by: if
wonsik 2013/04/10 06:29:22 Done.
+ WebContentsViewAndroid* view =
+ static_cast<WebContentsViewAndroid*>(web_contents_->GetView());
+ if (view)
+ view->NotifyGeometryChange(player_id, rect);
+ }
+}
+
MediaPlayerBridge* MediaPlayerManagerAndroid::GetPlayer(int player_id) {
for (ScopedVector<MediaPlayerBridge>::iterator it = players_.begin();
it != players_.end(); ++it) {

Powered by Google App Engine
This is Rietveld 408576698