Location/size change notification when external rendering is enabled

webkit/media/android/webmediaplayer_manager_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/media/android/webmediaplayer_manager_android.h"
 
+#include "ui/gfx/rect_f.h"
 #include "webkit/media/android/webmediaplayer_android.h"
 
 namespace webkit_media {
 
 WebMediaPlayerManagerAndroid::WebMediaPlayerManagerAndroid()
     : next_media_player_id_(0),
       fullscreen_frame_(NULL) {
 }
 
 WebMediaPlayerManagerAndroid::~WebMediaPlayerManagerAndroid() {
@@ skipping 45 matching lines @@
 }
 
 void WebMediaPlayerManagerAndroid::DidExitFullscreen() {
   fullscreen_frame_ = NULL;
 }
 
 bool WebMediaPlayerManagerAndroid::IsInFullscreen(WebKit::WebFrame* frame) {
   return fullscreen_frame_ == frame;
 }
 
+void WebMediaPlayerManagerAndroid::GetGeometryChanges(
+    std::map<int, gfx::RectF>* changes) {
+  DCHECK(changes->empty());
+  std::map<int32, WebMediaPlayerAndroid*>::iterator player_it;

[palmer, 2013/04/05 18:05:15]

This should really be scoped to the for loop. If the problem is that it makes
the line too long, maybe use a typedef?

Note also that you are using an int32 to index a map whose key type is int. That
is not guaranteed to work; use the same type in both places.

[wonsik, 2013/04/08 04:39:22]

Done.

+  for (player_it = media_players_.begin(); player_it != media_players_.end();
+       ++player_it) {
+    WebMediaPlayerAndroid* player = player_it->second;
+
+    if (player && player->hasVideo()) {
+      gfx::RectF rect;
+      if (player->GetGeometryChange(&rect)) {
+        (*changes)[player_it->first] = rect;
+      }
+    }
+  }
+}
+
 }  // namespace webkit_media