Location/size change notification when external rendering is enabled

content/renderer/media/webmediaplayer_proxy_impl_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/webmediaplayer_proxy_impl_android.h"
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "content/common/media/media_player_messages.h"
 #include "webkit/media/android/webmediaplayer_impl_android.h"
@@ skipping 167 matching lines @@
 }
 
 void WebMediaPlayerProxyImplAndroid::ExitFullscreen(int player_id) {
   Send(new MediaPlayerHostMsg_ExitFullscreen(routing_id(), player_id));
 }
 
 void WebMediaPlayerProxyImplAndroid::RequestExternalSurface(int player_id) {
   Send(new MediaPlayerHostMsg_RequestExternalSurface(routing_id(), player_id));
 }
 
+#if defined(GOOGLE_TV)

[palmer, 2013/04/09 19:02:41]

So, the only client that sends this IPC message is the renderers on Google TV
systems, but the browser-side end-point is always built in? Regardless of safety
and attack surface, is that a bloat problem?

I see scherkus asked about this too. I think you should either guard all the
code with defined(GOOGLE_TV), or guard none of it (iff it really will be used
everywhere eventually).

[scherkus (not reviewing), 2013/04/09 23:43:39]

I believe the long term path is to move away hole punching, in which case we
should try to wrap as much hole-punching related code w/ defined(GOOGLE_TV).

Even if we're wrong it's easy to drop the defines. Not so much the other way
around (i.e., determining which functions are unused hole punching code)

[wonsik, 2013/04/10 06:29:22]

Done --- IPC and related code ifdef'ed except for Java code and JNI hooks where
there is no obvious way to guard them.

+void WebMediaPlayerProxyImplAndroid::DidCommitCompositorFrame() {
+  std::map<int, gfx::RectF> geometry_change;
+  manager_->GetGeometryChanges(&geometry_change);
+  for (std::map<int, gfx::RectF>::iterator it = geometry_change.begin();
+       it != geometry_change.end();
+       ++it) {
+    Send(new MediaPlayerHostMsg_NotifyGeometryChange(routing_id(),
+                                                     it->first,
+                                                     it->second));
+  }
+}
+#endif
+
 webkit_media::WebMediaPlayerImplAndroid*
     WebMediaPlayerProxyImplAndroid::GetWebMediaPlayer(int player_id) {
   return static_cast<webkit_media::WebMediaPlayerImplAndroid*>(
       manager_->GetMediaPlayer(player_id));
 }
 
 }  // namespace content