Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 13688002: [chromedriver] Update Java tests to latest selenium release, 2.31. (Closed)

Created:
7 years, 8 months ago by kkania
Modified:
7 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[chromedriver] Update Java tests to latest selenium release, 2.31. Also change test runner to filter tests based on the Google Test (C++) filter format. Include all standard selenium java tests, even those that were ignored for Chrome (regardless of reason). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192756

Patch Set 1 : #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -30 lines) Patch
M README.chromium View 1 2 chunks +9 lines, -8 lines 0 comments Download
A common.zip View Binary file 0 comments Download
M patch.diff View 1 4 chunks +85 lines, -22 lines 0 comments Download
M test-standalone.jar View Binary file 0 comments Download

Messages

Total messages: 4 (0 generated)
kkania
I won't commit this until my other CL has been approved
7 years, 8 months ago (2013-04-05 01:00:30 UTC) #1
chrisgao (Use stgao instead)
lgtm with nits. https://codereview.chromium.org/13688002/diff/1004/README.chromium File README.chromium (right): https://codereview.chromium.org/13688002/diff/1004/README.chromium#newcode22 README.chromium:22: - Zip all of common into ...
7 years, 8 months ago (2013-04-05 15:41:09 UTC) #2
kkania
done, also added to patch stuff for actually running the HTML5 java tests. A lot ...
7 years, 8 months ago (2013-04-05 17:31:26 UTC) #3
kkania
7 years, 8 months ago (2013-04-06 16:07:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r192756 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698