Issue 1368793004: fix inference of object members when a method has no target

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1368793004: fix inference of object members when a method has no target (Closed)

Created:
5 years, 2 months ago by Jennifer Messerly

Modified:
5 years, 2 months ago

Reviewers:
Leaf, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

fix inference of object members when a method has no target we incorrectly thought `toString()` was a call to `Object.toString()` See https://github.com/dart-lang/dev_compiler/issues/349 for more context R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/c09b338e255ea897e9672f9611e32f9f9430ba3c

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -0 lines)			Patch
	M	pkg/analyzer/lib/src/generated/static_type_analyzer.dart	View		1 chunk	+9 lines, -0 lines	0 comments	Download
	M	pkg/analyzer/test/generated/resolver_test.dart	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Jennifer Messerly

5 years, 2 months ago (2015-09-26 00:23:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c09b338e255ea897e9672f9611e32f9f9430ba3c (presubmit successful).