Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1368773005: Enable timerfd in libusb. (Closed)

Created:
5 years, 2 months ago by pneubeck (no reviews)
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable timerfd in libusb. This compile flag enables correct timeout handling in libusb. Without it, timeouts of e.g. interrupt transfers are ignored in most cases. BUG=535950 Committed: https://crrev.com/072a708b34caad4e046623c2a1c237dc751b92b9 Cr-Commit-Position: refs/heads/master@{#351072}

Patch Set 1 #

Patch Set 2 : Sort preprocessor flags alphabetically. #

Patch Set 3 : Don't change OS X, udpate BUILD.gn as well. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/libusb/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libusb/libusb.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
pneubeck (no reviews)
ptal
5 years, 2 months ago (2015-09-25 11:38:32 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368773005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368773005/1
5 years, 2 months ago (2015-09-25 11:38:49 UTC) #4
Reilly Grant (use Gerrit)
lgtm
5 years, 2 months ago (2015-09-25 16:42:59 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368773005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368773005/40001
5 years, 2 months ago (2015-09-28 09:49:14 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-28 10:28:22 UTC) #9
pneubeck (no reviews)
ptal (feel free to press commit button)
5 years, 2 months ago (2015-09-28 11:20:28 UTC) #10
Reilly Grant (use Gerrit)
lgtm
5 years, 2 months ago (2015-09-28 15:13:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368773005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368773005/40001
5 years, 2 months ago (2015-09-28 15:13:45 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-28 15:18:33 UTC) #14
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/072a708b34caad4e046623c2a1c237dc751b92b9 Cr-Commit-Position: refs/heads/master@{#351072}
5 years, 2 months ago (2015-09-28 15:19:21 UTC) #15
pavely
5 years, 2 months ago (2015-09-28 18:16:52 UTC) #16
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1369373002/ by pavely@chromium.org.

The reason for reverting is: Speculatively reverting change that might cause
failures:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux...
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux....

Powered by Google App Engine
This is Rietveld 408576698