Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: src/objects.h

Issue 1368753003: Add C++ implementation of Object.defineProperties (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: preview -- needs refactoring Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/lookup.h ('k') | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 6838f275b9643089032532046f816e5335797637..cb00bb2eb106fbb44d25b6ddd511b169a84c11f0 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -1827,12 +1827,13 @@ class JSReceiver: public HeapObject {
Handle<JSReceiver> object);
enum KeyCollectionType { OWN_ONLY, INCLUDE_PROTOS };
+ enum IncludeSymbolNamedProperties { SKIP_SYMBOLS, INCLUDE_SYMBOLS };
// Computes the enumerable keys for a JSObject. Used for implementing
// "for (n in object) { }".
MUST_USE_RESULT static MaybeHandle<FixedArray> GetKeys(
- Handle<JSReceiver> object,
- KeyCollectionType type);
+ Handle<JSReceiver> object, KeyCollectionType type,
+ IncludeSymbolNamedProperties include_symbols = SKIP_SYMBOLS);
private:
DISALLOW_IMPLICIT_CONSTRUCTORS(JSReceiver);
@@ -2030,7 +2031,7 @@ class JSObject: public JSReceiver {
// Defines an AccessorPair property on the given object.
// TODO(mstarzinger): Rename to SetAccessor().
static MaybeHandle<Object> DefineAccessor(Handle<JSObject> object,
- Handle<Name> name,
+ Handle<Object> name,
Handle<Object> getter,
Handle<Object> setter,
PropertyAttributes attributes);
« no previous file with comments | « src/lookup.h ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698