chrome/browser/resources/settings/input/input.html - Issue 1368733002: Introduce cr-settings-input and eliminate cr-input

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/input/input.html

Issue 1368733002: Introduce cr-settings-input and eliminate cr-input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_532540_elim_cr_toggle_button

Patch Set: Elim unuseful bool support + nits Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/downloads_page/downloads_page.html ('K') | « chrome/browser/resources/settings/input/input.css ('k') | chrome/browser/resources/settings/input/input.js » ('j') | chrome/browser/resources/settings/internet_page/network_proxy.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/input/input.html

diff --git a/chrome/browser/resources/settings/checkbox/checkbox.html b/chrome/browser/resources/settings/input/input.html

similarity index 53%

copy from chrome/browser/resources/settings/checkbox/checkbox.html

copy to chrome/browser/resources/settings/input/input.html

index 8adebc1ddb4acc0a1c7b4ab74ae203738475385d..40d5720ca3d4dccf06617ff36aa3b966015db7ed 100644

--- a/chrome/browser/resources/settings/checkbox/checkbox.html

+++ b/chrome/browser/resources/settings/input/input.html

@@ -1,24 +1,24 @@

-<link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-checkbox.html">

+<link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input.html">

-<link rel="import" href="chrome://resources/cr_elements/v1_0/policy/cr_policy_indicator.html">

-<dom-module id="cr-settings-checkbox">

- <link rel="import" type="css" href="checkbox.css">

+<dom-module id="cr-settings-input">

+ <link rel="import" type="css" href="input.css">

<cr-events id="events"></cr-events>

<cr-settings-pref-tracker pref="[[pref]]"></cr-settings-pref-tracker>

- <paper-checkbox id="checkbox" checked="{{checked}}"

- disabled="[[checkboxDisabled_(disabled, pref)]]">

- <span id="mainLabel">{{label}}</span>

- <span id="subLabel">{{subLabel}}</span>

- </paper-checkbox>

+ <paper-input id="input" auto-validate

+ label="[[label]]" no-label-float="[[noLabelFloat]]"

+ value="{{value}}" error-message="[[errorMessage]]"

+ type="[[type]]" pattern="[[pattern]]" required="[[required]]"

+ on-blur="onBlur_" disabled="[[isDisabled_(disabled, pref)]]">

+ </paper-input>

<cr-policy-indicator pref="[[pref]]"></cr-policy-indicator>

</div>

</template>

- <script src="checkbox.js"></script>

+ <script src="input.js"></script>

</dom-module>