chrome/browser/resources/settings/search_engines_page/search_engine_entry.js - Issue 1368733002: Introduce cr-settings-input and eliminate cr-input

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

Issue 1368733002: Introduce cr-settings-input and eliminate cr-input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_532540_elim_cr_toggle_button

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/search_engine_entry.html ('k') | chrome/browser/resources/settings/search_engines_page/search_engines_list.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

diff --git a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

index db9e80d623dfd7031dfc0835dc6d5b881ccc39c6..9e3a00940ab2020f4f535de8b0f8cb99d6954689 100644

--- a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

+++ b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

@@ -53,7 +53,7 @@ Polymer({

/** @private */

fieldChanged_: function() {

// NOTE: This currently doesn't fire in response to a change event from the

- // cr-input, even though it should. This Polymer change should fix the

+ // paper-input, even though it should. This Polymer change should fix the

// issue: https://github.com/PolymerElements/paper-input/pull/33

chrome.searchEnginesPrivate.updateSearchEngine(

this.engine.guid,

@@ -63,4 +63,3 @@ Polymer({

this.makeNotEditable_();

}

});