chrome/browser/resources/settings/search_engines_page/search_engine_entry.html - Issue 1368733002: Introduce cr-settings-input and eliminate cr-input

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/search_engines_page/search_engine_entry.html

Issue 1368733002: Introduce cr-settings-input and eliminate cr-input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_532540_elim_cr_toggle_button

Patch Set: More feedback Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/input/input.js ('K') | « chrome/browser/resources/settings/search_engines_page/search_engine_entry.css ('k') | chrome/browser/resources/settings/search_engines_page/search_engine_entry.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">	1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">	2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">

3 <link rel="import" href="chrome://resources/cr_elements/v1_0/cr_input/cr_input.h tml">	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">

4	4

5 <dom-module id="cr-search-engine-entry">	5 <dom-module id="cr-search-engine-entry">

6 <link rel="import" type="css" href="search_engine_entry.css">	6 <link rel="import" type="css" href="search_engine_entry.css">

7 <template>	7 <template>

8 <div class="entry">	8 <div class="entry">

9 <div class="inputs">	9 <div class="inputs">

10 <cr-input id="domainField" class="narrow-input" auto-validate="false"	10 <paper-input id="domainField" disabled required

11 value="{{engine.name}}" on-change="fieldChanged_" disabled required>	11 class="narrow-input" auto-validate="false"

12 </cr-input>	12 value="{{engine.name}}" on-change="fieldChanged_">

13 <cr-input id="keywordField" class="narrow-input" auto-validate="false"	13 </paper-input>

14 value="{{engine.keyword}}" on-change="fieldChanged_" disabled	14 <paper-input id="keywordField" disabled required

15 required>	15 class="narrow-input" auto-validate="false"

16 </cr-input>	16 value="{{engine.keyword}}" on-change="fieldChanged_">

17 <cr-input id="queryURLField" class="wide-input" auto-validate="false"	17 </paper-input>

18 value="{{engine.url}}" on-change="fieldChanged_" disabled required>	18 <paper-input id="queryURLField" disabled required

19 </cr-input>	19 class="wide-input" auto-validate="false"

	20 value="{{engine.url}}" on-change="fieldChanged_">

	21 </paper-input>

20 </div>	22 </div>

21 <div class="icons">	23 <div class="icons">

22 <iron-icon id="checkIcon" icon="check" on-click="makeDefault_" hidden>	24 <iron-icon id="checkIcon" icon="check" on-click="makeDefault_" hidden>

23 </iron-icon>	25 </iron-icon>

24 <iron-icon id="deleteIcon" icon="clear" on-click="deleteEngine_" hidden>	26 <iron-icon id="deleteIcon" icon="clear" on-click="deleteEngine_" hidden>

25 </iron-icon>	27 </iron-icon>

26 <iron-icon icon="settings" on-click="toggleEditable_"></iron-icon>	28 <iron-icon icon="settings" on-click="toggleEditable_"></iron-icon>

27 </div>	29 </div>

28 </div>	30 </div>

29 </template>	31 </template>

30 <script src="search_engine_entry.js"></script>	32 <script src="search_engine_entry.js"></script>

31 </dom-module>	33 </dom-module>

OLD	NEW