chrome/browser/resources/settings/input/input.html - Issue 1368733002: Introduce cr-settings-input and eliminate cr-input

Side by Side Diff: chrome/browser/resources/settings/input/input.html

Issue 1368733002: Introduce cr-settings-input and eliminate cr-input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_532540_elim_cr_toggle_button

Patch Set: More feedback Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/appearance_page/appearance_page.html ('K') | « chrome/browser/resources/settings/input/input.css ('k') | chrome/browser/resources/settings/input/input.js » ('j') | chrome/browser/resources/settings/input/input.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">	1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html">	2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">
	dschuyler 2015/09/24 20:39:05 Maybe consider using a higher 'similarity' to avoi Maybe consider using a higher 'similarity' to avoid connecting new files to unrelated files. e.g. git cl upload --similarity=70 (the default is 50%, and these two are likely over 50% similar). stevenjb 2015/09/24 21:22:15 shrug They are in fact similar enough that I fin Show quoted text On 2015/09/24 20:39:05, dschuyler wrote: > Maybe consider using a higher 'similarity' to avoid connecting new files to > unrelated files. e.g. git cl upload --similarity=70 > (the default is 50%, and these two are likely over 50% similar). shrug They are in fact similar enough that I find the diff if anything to be helpful.
3 <link rel="import" href="chrome://resources/cr_elements/v1_0/cr_events/cr_events .html">	3 <link rel="import" href="chrome://resources/cr_elements/v1_0/cr_events/cr_events .html">

4 <link rel="import" href="chrome://resources/cr_elements/v1_0/policy/cr_policy_in dicator.html">

5 <link rel="import" href="chrome://md-settings/policy_controllable/policy_control lable.html">	4 <link rel="import" href="chrome://md-settings/policy_controllable/policy_control lable.html">

6 <link rel="import" href="chrome://md-settings/pref_tracker/pref_tracker.html">	5 <link rel="import" href="chrome://md-settings/pref_tracker/pref_tracker.html">

7	6

8 <dom-module id="cr-settings-checkbox">	7 <dom-module id="cr-settings-input">

9 <link rel="import" type="css" href="checkbox.css">	8 <link rel="import" type="css" href="input.css">

10 <template>	9 <template>

11 <cr-events id="events"></cr-events>	10 <cr-events id="events"></cr-events>

12 <cr-settings-pref-tracker pref="[[pref]]"></cr-settings-pref-tracker>	11 <cr-settings-pref-tracker pref="[[pref]]"></cr-settings-pref-tracker>

13	12

14 <div id="outerDiv" class="layout horizontal center">	13 <div id="outerDiv" class="layout horizontal center">

15 <paper-checkbox id="checkbox" checked="{{checked}}"	14 <paper-input id="input" auto-validate

16 disabled="[[checkboxDisabled_(disabled, pref)]]">	15 label="[[label]]" no-label-float="[[noLabelFloat]]"

17 <span id="mainLabel">{{label}}</span>	16 value="{{value}}" error-message="[[errorMessage]]"

18 <span id="subLabel">{{subLabel}}</span>	17 type="[[type]]" pattern="[[pattern]]" required="[[required]]"

19 </paper-checkbox>	18 on-blur="onBlur_" disabled="[[isDisabled_(disabled, pref)]]">

	19 </paper-input>

20 <cr-policy-indicator pref="[[pref]]"></cr-policy-indicator>	20 <cr-policy-indicator pref="[[pref]]"></cr-policy-indicator>

21 </div>	21 </div>

22 </template>	22 </template>

23 <script src="checkbox.js"></script>	23 <script src="input.js"></script>

24 </dom-module>	24 </dom-module>

OLD	NEW