Introduce cr-settings-input and eliminate cr-input

chrome/browser/resources/settings/input/input.js

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+/**
+ * @fileoverview
+ * `cr-settings-input` is a single-line text field for user input associated
+ * with a pref value.
+ *
+ * Example:
+ *
+ *    <cr-settings-input></cr-settings-input>

[michaelpg, 2015/09/24 18:59:31]

exclude useless example IMO

[stevenjb, 2015/09/24 19:28:53]

Done.

+ *
+ * @element cr-settings-input
+ */
+Polymer({
+  is: 'cr-settings-input',
+
+  behaviors: [PolicyControllable],
+
+  properties: {
+    /**
+     * The preference object to control.
+     * @type {chrome.settingsPrivate.PrefObject|undefined}
+     */
+    pref: {
+      type: Object,
+      notify: true,
+      observer: 'prefChanged_'
+    },
+
+    /**
+     * The current value of the input, reflected to/from |pref|.
+     */
+    value: {
+      type: String,
+      value: '',
+      notify: true,
+    },
+
+    /**
+     * Set to true to disable editing the input.
+     */
+    disabled: {
+      type: Boolean,
+      value: false,
+      reflectToAttribute: true
+    },
+
+    /** Propagate the label property. */
+    label: { type: String },
+
+    /** Propagate the no-label-float property. */
+    noLabelFloat: { type: Boolean, value: false },
+
+    /** Propagate the required property. */
+    required: { type: Boolean, value: false },
+
+    /** Propagate the pattern property. */
+    pattern: { type: String },
+
+    /** Propagate the type property. */
+    type: { type: String },
+
+    /** Propagate the errorMessage property. */
+    errorMessage: { type: String },
+  },
+
+  /**
+   * Focuses the 'input' element.
+   */
+  focus: function() {

[michaelpg, 2015/09/24 18:59:31]

opt nit: put ready() first

[stevenjb, 2015/09/24 19:28:52]

Done.

+    this.$.input.inputElement.focus();
+  },
+
+  /** @override */
+  ready: function() {
+    this.$.events.forward(this.$.input, ['change']);
+  },
+
+  /**
+   * Polymer changed observer for |pref|.
+   * @private
+   */
+  prefChanged_: function() {
+    if (!this.pref)
+      return;
+
+    // Ignore updates while the input is focused so that user input is not
+    // overwritten.
+    if (this.$.input.focused)
+      return;
+
+    if (this.pref.type == chrome.settingsPrivate.PrefType.NUMBER ||
+        this.pref.type == chrome.settingsPrivate.PrefType.BOOLEAN) {
+      this.value = this.pref.value.toString();
+    } else {
+      assert(this.pref.type != chrome.settingsPrivate.PrefType.LIST);

[michaelpg, 2015/09/24 18:59:31]

nit... i'd rather assert it's a string or url type. otherwise when other
PrefTypes get added (dictionary) this assert becomes incomplete.

[stevenjb, 2015/09/24 19:28:53]

Done.

+      this.value = /** @type {string} */(this.pref.value);
+    }
+  },
+
+  /**
+   * Blur method for paper-input. Only update the pref value on a blur event.
+   * @private
+   */
+  onBlur_: function() {
+    if (!this.pref)
+      return;
+
+    if (this.pref.type == chrome.settingsPrivate.PrefType.NUMBER) {
+      var n = parseInt(this.value, 10);
+      if (isNaN(n)) {
+        console.error('Bad value for numerical pref: ' + this.value);

[michaelpg, 2015/09/24 18:59:30]

should we error when this.value == ''?

[stevenjb, 2015/09/24 19:28:53]

Hmm, maybe not. I'll go ahead and special case that as a no-op here.

[stevenjb, 2015/09/24 19:28:53]

Hmm, maybe not. I'll go ahead and special case that as a no-op here.

+        return;
+      }
+      this.set('pref.value', n);
+    } else if (this.pref.type == chrome.settingsPrivate.PrefType.BOOLEAN) {
+      this.set('pref.value', this.value == 'true');

[michaelpg, 2015/09/24 18:59:31]

This doesn't seem actually useful.

[stevenjb, 2015/09/24 19:28:53]

Fair. I'll assert instead.

[stevenjb, 2015/09/24 19:28:53]

Fair. I'll assert instead.

[michaelpg, 2015/09/24 19:42:14]

fyi, you've been double-saving comments lately... connectivity issues or a bug
with reitveld or an extension?

[stevenjb, 2015/09/24 19:59:59]

Yeah, I don't know WTF is up with that. Thought maybe it was just on my end.
Deleting extra comments for now.

+    } else {
+      assert(this.pref.type != chrome.settingsPrivate.PrefType.LIST);

[michaelpg, 2015/09/24 18:59:31]

same assert nit

[stevenjb, 2015/09/24 19:28:53]

Done.

+      this.set('pref.value', this.value);
+    }
+  },
+
+  /**
+   * @param {boolean} disabled
+   * @param {?chrome.settingsPrivate.PrefObject} pref
+   * @return {boolean} Whether the element should be disabled.
+   * @private
+   */
+  isDisabled_: function(disabled, pref) {
+    return disabled || this.isPolicyControlled(pref);
+  },
+});