Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 136873002: Add no-op NULL picture to bench_record. (Closed)

Created:
6 years, 11 months ago by mtklein
Modified:
6 years, 11 months ago
Reviewers:
Tom Hudson, tomhudson
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add no-op NULL picture to bench_record. Defaults of out/Release/bench_record are still fine; NULL's not too far off from stable at 900 loops. But for focus on NULL, I'd recommend something like out/Release/bench_record --loops 100000 --skps. Also: fail on failures, print 2 significant digits instead of fixed 4.2. BUG=skia:1850 Committed: http://code.google.com/p/skia/source/detail?r=13054

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -13 lines) Patch
M tools/bench_record.cpp View 1 chunk +26 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 11 months ago (2014-01-13 16:27:16 UTC) #1
tomhudson
LGTM. You're always adding a NULL record, even if skps is empty?
6 years, 11 months ago (2014-01-13 18:40:16 UTC) #2
mtklein
On 2014/01/13 18:40:16, tomhudson wrote: > LGTM. > > You're always adding a NULL record, ...
6 years, 11 months ago (2014-01-13 18:55:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/136873002/1
6 years, 11 months ago (2014-01-13 18:57:14 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-13 19:09:38 UTC) #5
Message was sent while issue was closed.
Change committed as 13054

Powered by Google App Engine
This is Rietveld 408576698