Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2180)

Unified Diff: dbus/property.cc

Issue 1368713002: dbus: add support for synchronous PropertySet::Get (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dbus/property.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dbus/property.cc
diff --git a/dbus/property.cc b/dbus/property.cc
index b7a0c8be458bef4c5c0e35a4e2a3337e98658fab..234036c35db11ddd645a24c920e0a49afb8257c7 100644
--- a/dbus/property.cc
+++ b/dbus/property.cc
@@ -133,6 +133,35 @@ void PropertySet::OnGet(PropertyBase* property, GetCallback callback,
callback.Run(response);
}
+bool PropertySet::GetAndBlock(PropertyBase* property) {
+ MethodCall method_call(kPropertiesInterface, kPropertiesGet);
+ MessageWriter writer(&method_call);
+ writer.AppendString(interface());
+ writer.AppendString(property->name());
+
+ DCHECK(object_proxy_);
+ scoped_ptr<dbus::Response> response(
+ object_proxy_->CallMethodAndBlock(&method_call,
+ ObjectProxy::TIMEOUT_USE_DEFAULT));
+
+ if (!response.get()) {
+ LOG(WARNING) << property->name() << ": GetAndBlock: failed.";
+ return false;
+ }
+
+ MessageReader reader(response.get());
+ if (property->PopValueFromReader(&reader)) {
+ property->set_valid(true);
+ NotifyPropertyChanged(property->name());
+ } else {
+ if (property->is_valid()) {
+ property->set_valid(false);
+ NotifyPropertyChanged(property->name());
+ }
+ }
+ return true;
+}
+
void PropertySet::GetAll() {
MethodCall method_call(kPropertiesInterface, kPropertiesGetAll);
MessageWriter writer(&method_call);
@@ -184,7 +213,7 @@ bool PropertySet::SetAndBlock(PropertyBase* property) {
DCHECK(object_proxy_);
scoped_ptr<dbus::Response> response(
object_proxy_->CallMethodAndBlock(&method_call,
- ObjectProxy::TIMEOUT_USE_DEFAULT));
+ ObjectProxy::TIMEOUT_USE_DEFAULT));
if (response.get())
return true;
return false;
« no previous file with comments | « dbus/property.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698