Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: chrome/common/crash_keys_unittest.cc

Issue 1368703002: Use a class instead of several separate globals in crash_logging.cc. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/crash_keys_unittest.cc
diff --git a/chrome/common/crash_keys_unittest.cc b/chrome/common/crash_keys_unittest.cc
index 5dd04b2235b2405097558cb44eafc6d74b73b3c1..94759053ccbf2c39b298dfe14f1edd81dae97a38 100644
--- a/chrome/common/crash_keys_unittest.cc
+++ b/chrome/common/crash_keys_unittest.cc
@@ -8,6 +8,7 @@
#include <set>
#include <string>
+#include "base/at_exit.h"
#include "base/command_line.h"
#include "base/compiler_specific.h"
#include "base/debug/crash_logging.h"
@@ -25,7 +26,6 @@ class CrashKeysTest : public testing::Test {
}
void TearDown() override {
- base::debug::ResetCrashLoggingForTesting();
self_ = NULL;
}
@@ -53,6 +53,7 @@ class CrashKeysTest : public testing::Test {
static CrashKeysTest* self_;
std::map<std::string, std::string> keys_;
+ base::ShadowingAtExitManager at_exit_manager_;
danakj 2015/09/24 21:08:36 ditto
Robert Sesek 2015/09/24 21:28:19 Done.
};
CrashKeysTest* CrashKeysTest::self_ = NULL;
« base/debug/crash_logging_unittest.cc ('K') | « base/debug/crash_logging_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698