Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13687007: Remove PLATFORM(BLACKBERRY) support. (Closed)

Created:
7 years, 8 months ago by eae
Modified:
7 years, 8 months ago
CC:
blink-reviews, jamesr, Stephen Chennney, Nate Chapin, jchaffraix+rendering, abarth-chromium
Visibility:
Public.

Description

Remove PLATFORM(BLACKBERRY) support. Remove BLACKBERRY platform define and all code guarded by it. TESTED=Covered by existing tests BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=147825

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -426 lines) Patch
M Source/WTF/wtf/Assertions.cpp View 3 chunks +0 lines, -8 lines 0 comments Download
M Source/WTF/wtf/FeatureDefines.h View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/WTF/wtf/Platform.h View 6 chunks +4 lines, -14 lines 0 comments Download
M Source/WTF/wtf/text/AtomicString.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/WTF/wtf/text/StringImpl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/WTF/wtf/text/WTFString.h View 2 chunks +0 lines, -13 lines 0 comments Download
M Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/dom/TouchEvent.h View 2 chunks +0 lines, -10 lines 0 comments Download
M Source/WebCore/dom/TouchEvent.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
M Source/WebCore/history/HistoryItem.h View 3 chunks +0 lines, -12 lines 0 comments Download
M Source/WebCore/loader/CookieJar.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/WebCore/loader/PingLoader.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/WebCore/loader/cache/CachedResource.cpp View 2 chunks +2 lines, -2 lines 2 comments Download
M Source/WebCore/loader/icon/IconLoader.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebCore/page/NavigatorBase.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/page/Settings.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/AsyncFileSystem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/Cursor.h View 5 chunks +2 lines, -9 lines 0 comments Download
M Source/WebCore/platform/KURL.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/WebCore/platform/MIMETypeRegistry.cpp View 2 chunks +0 lines, -76 lines 0 comments Download
M Source/WebCore/platform/PlatformKeyboardEvent.h View 5 chunks +0 lines, -23 lines 0 comments Download
M Source/WebCore/platform/PlatformMouseEvent.h View 3 chunks +0 lines, -10 lines 0 comments Download
M Source/WebCore/platform/PlatformTouchEvent.h View 2 chunks +0 lines, -31 lines 0 comments Download
M Source/WebCore/platform/PlatformTouchPoint.h View 2 chunks +0 lines, -12 lines 0 comments Download
M Source/WebCore/platform/ScrollAnimatorNone.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/platform/graphics/ANGLEWebKitBridge.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/graphics/BitmapImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/graphics/DisplayRefreshMonitor.h View 3 chunks +0 lines, -22 lines 0 comments Download
M Source/WebCore/platform/graphics/DisplayRefreshMonitor.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebCore/platform/graphics/FloatRect.h View 2 chunks +0 lines, -13 lines 0 comments Download
M Source/WebCore/platform/graphics/FontCache.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/WebCore/platform/graphics/FontPlatformData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/graphics/Gradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/graphics/GraphicsContext3D.h View 2 chunks +0 lines, -10 lines 0 comments Download
M Source/WebCore/platform/graphics/GraphicsLayerClient.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/WebCore/platform/graphics/MediaPlayer.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebCore/platform/graphics/NativeImagePtr.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/platform/graphics/OpenGLESShims.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/platform/graphics/Path.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/WebCore/platform/graphics/PlatformLayer.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/WebCore/platform/graphics/filters/CustomFilterValidatedProgram.h View 3 chunks +2 lines, -9 lines 0 comments Download
M Source/WebCore/platform/graphics/filters/CustomFilterValidatedProgram.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/graphics/filters/FilterOperation.h View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/WebCore/platform/graphics/gpu/DrawingBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/graphics/skia/PathSkia.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/WebCore/platform/network/NetworkStateNotifier.h View 2 chunks +1 line, -5 lines 0 comments Download
M Source/WebCore/platform/network/ResourceHandle.h View 2 chunks +1 line, -5 lines 0 comments Download
M Source/WebCore/platform/network/ResourceHandleInternal.h View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/WebCore/platform/network/ResourceRequestBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/text/TextChecking.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/rendering/RenderLayer.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/WebCore/rendering/RenderLayerBacking.cpp View 2 chunks +0 lines, -19 lines 0 comments Download
M Source/WebCore/rendering/RenderObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/workers/DefaultSharedWorkerRepository.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebCore/workers/Worker.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebCore/workers/WorkerContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/workers/WorkerScriptLoader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/workers/WorkerScriptLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/xml/XMLHttpRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
eae
7 years, 8 months ago (2013-04-06 00:45:08 UTC) #1
eseidel
Its really amazing how much code poop there is from BlackBerry all over the source ...
7 years, 8 months ago (2013-04-06 01:36:47 UTC) #2
eae
Yeah, to be fair many of the other ports added an equivalent amount.
7 years, 8 months ago (2013-04-06 01:58:22 UTC) #3
eae
https://codereview.chromium.org/13687007/diff/1/Source/WebCore/loader/cache/CachedResource.cpp File Source/WebCore/loader/cache/CachedResource.cpp (left): https://codereview.chromium.org/13687007/diff/1/Source/WebCore/loader/cache/CachedResource.cpp#oldcode152 Source/WebCore/loader/cache/CachedResource.cpp:152: #if PLATFORM(CHROMIUM) || PLATFORM(BLACKBERRY) On 2013/04/06 01:36:47, Eric Seidel ...
7 years, 8 months ago (2013-04-06 01:59:05 UTC) #4
eae
7 years, 8 months ago (2013-04-08 17:10:42 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 manually as r147825 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698