components/sync_driver/data_type_controller.h - Issue 1368683003: USS SyncContextProxy / data type activation refactoring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/data_type_controller.h

Issue 1368683003: USS SyncContextProxy / data type activation refactoring (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR feedback Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync_driver/backend_data_type_configurer.h ('k') | components/sync_driver/data_type_manager_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_driver/data_type_controller.h

diff --git a/components/sync_driver/data_type_controller.h b/components/sync_driver/data_type_controller.h

index d9635d69582f954bd047fa7267b2d0ead0701a5f..2c701c091045464c4c45e2f5442da248585beb6c 100644

--- a/components/sync_driver/data_type_controller.h

+++ b/components/sync_driver/data_type_controller.h

@@ -149,11 +149,6 @@ class DataTypeController

const scoped_refptr<base::SingleThreadTaskRunner>& ui_thread,

const base::Closure& error_callback);

- // If the DTC is waiting for models to load, once the models are

- // loaded the datatype service will call this function on DTC to let

- // us know that it is safe to start associating.

- virtual void OnModelLoaded() = 0;

~DataTypeController() override;

// The callback that will be invoked when an unrecoverable error occurs.

« no previous file with comments | « components/sync_driver/backend_data_type_configurer.h ('k') | components/sync_driver/data_type_manager_impl_unittest.cc » ('j') | no next file with comments »