chrome/browser/sync/glue/sync_backend_host_impl.h - Issue 1368683003: USS SyncContextProxy / data type activation refactoring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/sync_backend_host_impl.h

Issue 1368683003: USS SyncContextProxy / data type activation refactoring (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR feedback Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/non_frontend_data_type_controller_mock.h ('k') | chrome/browser/sync/glue/sync_backend_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/sync_backend_host_impl.h

diff --git a/chrome/browser/sync/glue/sync_backend_host_impl.h b/chrome/browser/sync/glue/sync_backend_host_impl.h

index a89f8325205e83ce447bf543472c3508a9c2933d..b04c655d521c9996602a40a37d763ceed9efadc3 100644

--- a/chrome/browser/sync/glue/sync_backend_host_impl.h

+++ b/chrome/browser/sync/glue/sync_backend_host_impl.h

@@ -112,11 +112,15 @@ class SyncBackendHostImpl

const base::Callback<void(syncer::ModelTypeSet, syncer::ModelTypeSet)>&

ready_task,

const base::Callback<void()>& retry_callback) override;

- void ActivateDataType(

+ void ActivateDirectoryDataType(

syncer::ModelType type,

syncer::ModelSafeGroup group,

sync_driver::ChangeProcessor* change_processor) override;

- void DeactivateDataType(syncer::ModelType type) override;

+ void DeactivateDirectoryDataType(syncer::ModelType type) override;

+ void ActivateNonBlockingDataType(

+ syncer::ModelType type,

+ scoped_ptr<syncer_v2::ActivationContext>) override;

+ void DeactivateNonBlockingDataType(syncer::ModelType type) override;

void EnableEncryptEverything() override;

syncer::UserShare* GetUserShare() const override;

scoped_ptr<syncer_v2::SyncContextProxy> GetSyncContextProxy() override;