chrome/browser/sync/glue/non_frontend_data_type_controller.cc - Issue 1368683003: USS SyncContextProxy / data type activation refactoring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/non_frontend_data_type_controller.cc

Issue 1368683003: USS SyncContextProxy / data type activation refactoring (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR feedback Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/non_frontend_data_type_controller.h ('k') | chrome/browser/sync/glue/non_frontend_data_type_controller_mock.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/non_frontend_data_type_controller.cc

diff --git a/chrome/browser/sync/glue/non_frontend_data_type_controller.cc b/chrome/browser/sync/glue/non_frontend_data_type_controller.cc

index 6762237fd893dfc4b92c523f2f7e90d431abb4c3..7985cd3f13ffff367cdcdde04a98f62d4ead9529 100644

--- a/chrome/browser/sync/glue/non_frontend_data_type_controller.cc

+++ b/chrome/browser/sync/glue/non_frontend_data_type_controller.cc

@@ -203,10 +203,6 @@ void NonFrontendDataTypeController::LoadModels(

model_load_callback.Run(type(), syncer::SyncError());

}

-void NonFrontendDataTypeController::OnModelLoaded() {

- NOTREACHED();

void NonFrontendDataTypeController::StartAssociating(

const StartCallback& start_callback) {

DCHECK_CURRENTLY_ON(BrowserThread::UI);