chrome/browser/download/notification/download_item_notification.cc - Issue 1368653002: Setting CommandLabel 'IDS_DOWNLOAD_NOTIFICATION_LABEL_OPEN" for finished Download Notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/notification/download_item_notification.cc

Issue 1368653002: Setting CommandLabel 'IDS_DOWNLOAD_NOTIFICATION_LABEL_OPEN" for finished Download Notification. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/download/notification/download_item_notification.cc

diff --git a/chrome/browser/download/notification/download_item_notification.cc b/chrome/browser/download/notification/download_item_notification.cc

index acc044c8812c0fa85f92465e3188225aef4eab83..31823f1f63f4688a6ec462702f6915960a0d650b 100644

--- a/chrome/browser/download/notification/download_item_notification.cc

+++ b/chrome/browser/download/notification/download_item_notification.cc

@@ -693,9 +693,9 @@ base::string16 DownloadItemNotification::GetCommandLabel(

switch (command) {

case DownloadCommands::OPEN_WHEN_COMPLETE:

if (item_ && !item_->IsDone())

- id = IDS_DOWNLOAD_STATUS_OPEN_WHEN_COMPLETE;

+ id = IDS_DOWNLOAD_NOTIFICATION_LABEL_OPEN_WHEN_COMPLETE;

else

- id = IDS_DOWNLOAD_STATUS_OPEN_WHEN_COMPLETE;

+ id = IDS_DOWNLOAD_NOTIFICATION_LABEL_OPEN;

break;

case DownloadCommands::PAUSE:

// Only for non menu.

« chrome/app/generated_resources.grd ('K') | « chrome/app/generated_resources.grd ('k') | no next file » | no next file with comments »