chrome/app/generated_resources.grd - Issue 1368653002: Setting CommandLabel 'IDS_DOWNLOAD_NOTIFICATION_LABEL_OPEN" for finished Download Notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/generated_resources.grd

Side-by-side diff isn't available for this file because of its large size.

Issue 1368653002: Setting CommandLabel 'IDS_DOWNLOAD_NOTIFICATION_LABEL_OPEN" for finished Download Notification. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: chrome/app/generated_resources.grd

diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd

index d1a7b62e8053cadaf5c814a0a13160745402051a..94251f8d123420e306b4bed2aebe7261daa497a1 100644

--- a/chrome/app/generated_resources.grd

+++ b/chrome/app/generated_resources.grd

@@ -1815,6 +1815,14 @@ Psst! Incognito mode <ph name="SHORTCUT_KEY">$1<ex>(Ctrl+Shift+N)</ex></ph> may

=1 {Downloaded a file}

other {Downloaded # files}}

</message>

+ <message name="IDS_DOWNLOAD_NOTIFICATION_LABEL_OPEN_WHEN_COMPLETE"

+ desc="Download notifications: Label for 'Open when download is complete' action button on notification">

+ Open when done

+ </message>

+ <message name="IDS_DOWNLOAD_NOTIFICATION_LABEL_OPEN"

asanka 2015/09/29 16:35:02 Format these consistently with the surrounding cod

Deepak 2015/09/30 04:18:14 Done.

+ desc="Download notifications: Label for 'Open download' action button on notification">

+ Open

+ </message>

<message name="IDS_DOWNLOAD_NOTIFICATION_STATUS"

desc="Size and units downloaded and total, the origin domain, and the current status od download.">

<ph name="DOWNLOAD_RECEIVED_AND_TOTAL">$1<ex>54/154 MB</ex></ph> from <ph name="DOWNLOAD_DOMAIN">$2<ex>example.com</ex></ph>, <ph name="SUB_STATUS_TEXT">$3<ex>24 secs remaining</ex></ph>

« no previous file with comments | « no previous file | chrome/browser/download/notification/download_item_notification.cc » ('j') | no next file with comments »