content/renderer/render_frame_impl.cc - Issue 1368643002: Add a signal to the scheduler that a navigation is expected

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1368643002: Add a signal to the scheduler that a navigation is expected (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Requested changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/scheduler/renderer/renderer_scheduler_impl.cc ('K') | « components/scheduler/renderer/renderer_web_scheduler_impl.cc ('k') | content/test/fake_renderer_scheduler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index 7bfd60754e4119e6170b7e8bc12b8352a0cf5052..0f8c407b82c31992d71c5e53b77ee5c220297cbd 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -1125,7 +1125,7 @@ void RenderFrameImpl::OnNavigate(

RenderThreadImpl* render_thread_impl = RenderThreadImpl::current();

// Can be NULL in tests.

if (render_thread_impl)

- render_thread_impl->GetRendererScheduler()->OnPageLoadStarted();

+ render_thread_impl->GetRendererScheduler()->OnNavigationStarted();

DCHECK(!base::CommandLine::ForCurrentProcess()->HasSwitch(

switches::kEnableBrowserSideNavigation));

TRACE_EVENT2("navigation", "RenderFrameImpl::OnNavigate", "id", routing_id_,

@@ -2778,7 +2778,7 @@ void RenderFrameImpl::didCommitProvisionalLoad(

render_thread_impl->histogram_customizer()->

RenderViewNavigatedToHost(GURL(GetLoadingUrl()).host(),

RenderView::GetRenderViewCount());

- render_thread_impl->GetRendererScheduler()->OnPageLoadStarted();

+ render_thread_impl->GetRendererScheduler()->OnNavigationStarted();

}