components/scheduler/renderer/renderer_scheduler_impl.h - Issue 1368643002: Add a signal to the scheduler that a navigation is expected

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/scheduler/renderer/renderer_scheduler_impl.h

Issue 1368643002: Add a signal to the scheduler that a navigation is expected (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: We do need ref counts! There can be multiple concurrent navigations. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/scheduler/renderer/renderer_scheduler.h ('K') | « components/scheduler/renderer/renderer_scheduler.h ('k') | components/scheduler/renderer/renderer_scheduler_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/scheduler/renderer/renderer_scheduler_impl.h

diff --git a/components/scheduler/renderer/renderer_scheduler_impl.h b/components/scheduler/renderer/renderer_scheduler_impl.h

index d5c43ef25e2c296a7dd970cc1810c99695384efd..e40cfe571be5164eb03bf51b547e822ceb51177b 100644

--- a/components/scheduler/renderer/renderer_scheduler_impl.h

+++ b/components/scheduler/renderer/renderer_scheduler_impl.h

@@ -54,7 +54,9 @@ class SCHEDULER_EXPORT RendererSchedulerImpl

void OnRendererVisible() override;

void OnRendererBackgrounded() override;

void OnRendererForegrounded() override;

- void OnPageLoadStarted() override;

+ void NavigationTaskPendingIncRef() override;

+ void NavigationTaskPendingDecRef() override;

+ void OnNavigationStarted() override;

bool IsHighPriorityWorkAnticipated() override;

bool ShouldYieldForHighPriorityWork() override;

bool CanExceedIdleDeadlineIfRequired() const override;

@@ -239,6 +241,7 @@ class SCHEDULER_EXPORT RendererSchedulerImpl

base::TimeTicks estimated_next_frame_begin;

base::TimeDelta expected_short_idle_period_duration;

int timer_queue_suspend_count; // TIMER_TASK_QUEUE suspended if non-zero.

+ int navigation_task_expected_count;

bool renderer_hidden;

bool renderer_backgrounded;

bool timer_queue_suspension_when_backgrounded_enabled;