Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 1368623003: Pending scripts can cause disposed documents to leak. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/loading/pending-script-leak-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 554 matching lines...) Expand 10 before | Expand all | Expand 10 after
565 m_docType = nullptr; 565 m_docType = nullptr;
566 m_focusedElement = nullptr; 566 m_focusedElement = nullptr;
567 m_hoverNode = nullptr; 567 m_hoverNode = nullptr;
568 m_activeHoverElement = nullptr; 568 m_activeHoverElement = nullptr;
569 m_titleElement = nullptr; 569 m_titleElement = nullptr;
570 m_documentElement = nullptr; 570 m_documentElement = nullptr;
571 m_contextFeatures = ContextFeatures::defaultSwitch(); 571 m_contextFeatures = ContextFeatures::defaultSwitch();
572 m_userActionElements.documentDidRemoveLastRef(); 572 m_userActionElements.documentDidRemoveLastRef();
573 m_associatedFormControls.clear(); 573 m_associatedFormControls.clear();
574 574
575 m_scriptRunner.clear();
575 detachParser(); 576 detachParser();
576 577
577 m_registrationContext.clear(); 578 m_registrationContext.clear();
578 579
579 // removeDetachedChildren() doesn't always unregister IDs, 580 // removeDetachedChildren() doesn't always unregister IDs,
580 // so tear down scope information upfront to avoid having stale references i n the map. 581 // so tear down scope information upfront to avoid having stale references i n the map.
581 destroyTreeScopeData(); 582 destroyTreeScopeData();
582 583
583 removeDetachedChildren(); 584 removeDetachedChildren();
584 585
(...skipping 5159 matching lines...) Expand 10 before | Expand all | Expand 10 after
5744 #ifndef NDEBUG 5745 #ifndef NDEBUG
5745 using namespace blink; 5746 using namespace blink;
5746 void showLiveDocumentInstances() 5747 void showLiveDocumentInstances()
5747 { 5748 {
5748 Document::WeakDocumentSet& set = Document::liveDocumentSet(); 5749 Document::WeakDocumentSet& set = Document::liveDocumentSet();
5749 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 5750 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
5750 for (Document* document : set) 5751 for (Document* document : set)
5751 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().str ing().utf8().data()); 5752 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().str ing().utf8().data());
5752 } 5753 }
5753 #endif 5754 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/loading/pending-script-leak-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698