Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: third_party/WebKit/Source/core/css/resolver/ElementStyleResources.h

Issue 1368613002: Replace RawPtr with RefPtr on StylePendingImage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix image set caching logic Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/resolver/ElementStyleResources.h
diff --git a/third_party/WebKit/Source/core/css/resolver/ElementStyleResources.h b/third_party/WebKit/Source/core/css/resolver/ElementStyleResources.h
index ce8a6c1d621a844bca39a86ef34ca5b42629626d..61c1eae151c05adc88df3a9115c8606e61b1b3b1 100644
--- a/third_party/WebKit/Source/core/css/resolver/ElementStyleResources.h
+++ b/third_party/WebKit/Source/core/css/resolver/ElementStyleResources.h
@@ -41,8 +41,8 @@ class FilterOperation;
class StyleImage;
class TextLinkColors;
+using PendingImagePropertySet = HashSet<CSSPropertyID>;
using PendingSVGDocumentMap = WillBeHeapHashMap<RawPtrWillBeMember<FilterOperation>, RefPtrWillBeMember<CSSSVGDocumentValue>>;
-using PendingImagePropertyMap = WillBeHeapHashMap<CSSPropertyID, RefPtrWillBeMember<CSSValue>>;
// Holds information about resources, requested by stylesheets.
// Lifetime: per-element style resolve.
@@ -59,7 +59,7 @@ public:
PassRefPtrWillBeRawPtr<StyleImage> setOrPendingFromValue(CSSPropertyID, CSSImageSetValue*);
PassRefPtrWillBeRawPtr<StyleImage> cursorOrPendingFromValue(CSSPropertyID, CSSCursorImageValue*);
- const PendingImagePropertyMap& pendingImageProperties() const { return m_pendingImageProperties; }
+ const PendingImagePropertySet& pendingImageProperties() const { return m_pendingImageProperties; }
const PendingSVGDocumentMap& pendingSVGDocuments() const { return m_pendingSVGDocuments; }
void clearPendingImageProperties();
@@ -71,7 +71,7 @@ public:
void addPendingSVGDocument(FilterOperation*, CSSSVGDocumentValue*);
private:
- PendingImagePropertyMap m_pendingImageProperties;
+ PendingImagePropertySet m_pendingImageProperties;
PendingSVGDocumentMap m_pendingSVGDocuments;
float m_deviceScaleFactor;
};

Powered by Google App Engine
This is Rietveld 408576698