Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Side by Side Diff: third_party/WebKit/Source/core/style/StylePendingImage.h

Issue 1368613002: Replace RawPtr with RefPtr on StylePendingImage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix image set caching logic Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/page/PageSerializer.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 28 matching lines...) Expand all
39 // style resolution, in order to avoid loading images that are not referenced by the final style. 39 // style resolution, in order to avoid loading images that are not referenced by the final style.
40 // They should never exist in a ComputedStyle after it has been returned from th e style selector. 40 // They should never exist in a ComputedStyle after it has been returned from th e style selector.
41 41
42 class StylePendingImage final : public StyleImage { 42 class StylePendingImage final : public StyleImage {
43 public: 43 public:
44 static PassRefPtrWillBeRawPtr<StylePendingImage> create(CSSValue* value) 44 static PassRefPtrWillBeRawPtr<StylePendingImage> create(CSSValue* value)
45 { 45 {
46 return adoptRefWillBeNoop(new StylePendingImage(value)); 46 return adoptRefWillBeNoop(new StylePendingImage(value));
47 } 47 }
48 48
49 WrappedImagePtr data() const override { return m_value; } 49 WrappedImagePtr data() const override { return m_value.get(); }
50 50
51 PassRefPtrWillBeRawPtr<CSSValue> cssValue() const override { return m_value; } 51 PassRefPtrWillBeRawPtr<CSSValue> cssValue() const override { return m_value; }
52 52
53 PassRefPtrWillBeRawPtr<CSSValue> computedCSSValue() const override 53 PassRefPtrWillBeRawPtr<CSSValue> computedCSSValue() const override
54 { 54 {
55 ASSERT_NOT_REACHED(); 55 ASSERT_NOT_REACHED();
56 return nullptr; 56 return nullptr;
57 } 57 }
58 58
59 CSSImageValue* cssImageValue() const { return m_value->isImageValue() ? toCS SImageValue(m_value) : 0; } 59 CSSImageValue* cssImageValue() const { return m_value->isImageValue() ? toCS SImageValue(m_value.get()) : 0; }
60 CSSImageGeneratorValue* cssImageGeneratorValue() const { return m_value->isI mageGeneratorValue() ? toCSSImageGeneratorValue(m_value) : 0; } 60 CSSImageGeneratorValue* cssImageGeneratorValue() const { return m_value->isI mageGeneratorValue() ? toCSSImageGeneratorValue(m_value.get()) : 0; }
61 CSSCursorImageValue* cssCursorImageValue() const { return m_value->isCursorI mageValue() ? toCSSCursorImageValue(m_value) : 0; } 61 CSSCursorImageValue* cssCursorImageValue() const { return m_value->isCursorI mageValue() ? toCSSCursorImageValue(m_value.get()) : 0; }
62 CSSImageSetValue* cssImageSetValue() const { return m_value->isImageSetValue () ? toCSSImageSetValue(m_value) : 0; } 62 CSSImageSetValue* cssImageSetValue() const { return m_value->isImageSetValue () ? toCSSImageSetValue(m_value.get()) : 0; }
63 63
64 LayoutSize imageSize(const LayoutObject*, float /*multiplier*/) const overri de { return LayoutSize(); } 64 LayoutSize imageSize(const LayoutObject*, float /*multiplier*/) const overri de { return LayoutSize(); }
65 bool imageHasRelativeWidth() const override { return false; } 65 bool imageHasRelativeWidth() const override { return false; }
66 bool imageHasRelativeHeight() const override { return false; } 66 bool imageHasRelativeHeight() const override { return false; }
67 void computeIntrinsicDimensions(const LayoutObject*, Length& /* intrinsicWid th */ , Length& /* intrinsicHeight */, FloatSize& /* intrinsicRatio */) override { } 67 void computeIntrinsicDimensions(const LayoutObject*, Length& /* intrinsicWid th */ , Length& /* intrinsicHeight */, FloatSize& /* intrinsicRatio */) override { }
68 bool usesImageContainerSize() const override { return false; } 68 bool usesImageContainerSize() const override { return false; }
69 void setContainerSizeForLayoutObject(const LayoutObject*, const IntSize&, fl oat) override { } 69 void setContainerSizeForLayoutObject(const LayoutObject*, const IntSize&, fl oat) override { }
70 void addClient(LayoutObject*) override { } 70 void addClient(LayoutObject*) override { }
71 void removeClient(LayoutObject*) override { } 71 void removeClient(LayoutObject*) override { }
72 PassRefPtr<Image> image(LayoutObject*, const IntSize&) const override 72 PassRefPtr<Image> image(LayoutObject*, const IntSize&) const override
73 { 73 {
74 ASSERT_NOT_REACHED(); 74 ASSERT_NOT_REACHED();
75 return nullptr; 75 return nullptr;
76 } 76 }
77 bool knownToBeOpaque(const LayoutObject*) const override { return false; } 77 bool knownToBeOpaque(const LayoutObject*) const override { return false; }
78 78
79 DEFINE_INLINE_VIRTUAL_TRACE() 79 DEFINE_INLINE_VIRTUAL_TRACE()
80 { 80 {
81 visitor->trace(m_value); 81 visitor->trace(m_value);
82 StyleImage::trace(visitor); 82 StyleImage::trace(visitor);
83 } 83 }
84 84
85 private: 85 private:
86 explicit StylePendingImage(CSSValue* value) 86 explicit StylePendingImage(CSSValue* value)
87 : m_value(value) 87 : m_value(value)
88 { 88 {
89 m_isPendingImage = true; 89 m_isPendingImage = true;
90 } 90 }
91 91
92 RawPtrWillBeMember<CSSValue> m_value; // Not retained; it owns us. 92 RefPtrWillBeMember<CSSValue> m_value;
93 }; 93 };
94 94
95 DEFINE_STYLE_IMAGE_TYPE_CASTS(StylePendingImage, isPendingImage()); 95 DEFINE_STYLE_IMAGE_TYPE_CASTS(StylePendingImage, isPendingImage());
96 96
97 } 97 }
98 #endif 98 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/page/PageSerializer.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698